Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 186803005: [import] Use master document's origin to resolve CORS (Closed)

Created:
6 years, 9 months ago by Hajime Morrita
Modified:
6 years, 9 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

[import] Use master document's origin to resolve CORS This follows the spec change on https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905 where the fetch origin is given by the master document, not the referring document. This matches what CSP in imports is doing: Using master's CSP directive to regulate all the imports. In implemntation, it just set ResourceLoaderOptions::m_securityOrigin in FetchRequest::setCrossOriginAccessControl() because HTMLImportsController happened to pass the master' origin already. (That was wrong but wasn't covered by the test.) This change doesn't affect other FetchRequest client because in other callsite, m_securityOrigin is same as one that is used when it is absent. TEST=cors-same-origin.html BUG=348671 R=abarth@chromium.org, dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M LayoutTests/http/tests/htmlimports/cors-same-origin.html View 1 chunk +9 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/htmlimports/cors-same-origin-expected.txt View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/http/tests/htmlimports/resources/child-having-domain-policy.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/htmlimports/resources/cors-basic.cgi View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/cors-subimports.cgi View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/fetch/FetchRequest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hajime Morrita
PTAL?
6 years, 9 months ago (2014-03-05 00:07:21 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-05 00:25:46 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-05 01:10:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/186803005/1
6 years, 9 months ago (2014-03-05 01:11:48 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 16:34:31 UTC) #5
Message was sent while issue was closed.
Change committed as 168497

Powered by Google App Engine
This is Rietveld 408576698