Use custom profile names (if available) for signed in profiles

Use custom profile names (if available) for signed in profiles

The problem was that if the user was set to use the Gaia profile info, then we ignored any custom profile names that were synced. We shouldn't do that :) 

BUG=343730, 348187, 349000
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255273

[noms (inactive), 2014-03-05 14:52:24]

Hi Rachel,

I've moved the "check if the profile is using a default name" code into the
ProfileInfoCache, and saved it as a preference. This way we can correctly use
the synced, custom profile name if the user is signed in as well (before, the
code assumed that if you're using the Gaia name you should just use that,
regardless of what name the user synced).

I've also had to update 2 tests to use the new profile naming scheme (i.e.
Person 1 and Person 2), so that the profiles are counted as having default
names.

Please take a look. Thanks!

[rpetterson, 2014-03-05 22:10:44]

lgtm

[noms (inactive), 2014-03-05 22:13:34]

Thanks!

[noms (inactive), 2014-03-05 22:13:48]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-03-05 22:15:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/186803003/60001

[commit-bot: I haz the power, 2014-03-06 00:05:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/186803003/60001

[commit-bot: I haz the power, 2014-03-06 02:49:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/186803003/60001

[commit-bot: I haz the power, 2014-03-06 03:14:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/186803003/60001

[commit-bot: I haz the power, 2014-03-06 06:00:39]

Change committed as 255273