Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: tools/gn/substitution_writer_unittest.cc

Issue 1868023002: Add GN output prefix override and allow empty output extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/substitution_writer.cc ('k') | tools/gn/target.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 #include "tools/gn/err.h" 9 #include "tools/gn/err.h"
10 #include "tools/gn/escape.h" 10 #include "tools/gn/escape.h"
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 261
262 // Test that we handle paths that end up in the root build dir properly 262 // Test that we handle paths that end up in the root build dir properly
263 // (no leading "./" or "/"). 263 // (no leading "./" or "/").
264 SubstitutionPattern pattern; 264 SubstitutionPattern pattern;
265 ASSERT_TRUE(pattern.Parse("{{root_out_dir}}/{{target_output_name}}.so", 265 ASSERT_TRUE(pattern.Parse("{{root_out_dir}}/{{target_output_name}}.so",
266 nullptr, &err)); 266 nullptr, &err));
267 267
268 OutputFile output = SubstitutionWriter::ApplyPatternToLinkerAsOutputFile( 268 OutputFile output = SubstitutionWriter::ApplyPatternToLinkerAsOutputFile(
269 &target, tool, pattern); 269 &target, tool, pattern);
270 EXPECT_EQ("./libbaz.so", output.value()); 270 EXPECT_EQ("./libbaz.so", output.value());
271
272 // Output extensions can be overridden.
273 target.set_output_extension("extension");
274 EXPECT_EQ(".extension",
275 SubstitutionWriter::GetLinkerSubstitution(
276 &target, tool, SUBSTITUTION_OUTPUT_EXTENSION));
277 target.set_output_extension("");
278 EXPECT_EQ("",
279 SubstitutionWriter::GetLinkerSubstitution(
280 &target, tool, SUBSTITUTION_OUTPUT_EXTENSION));
271 } 281 }
OLDNEW
« no previous file with comments | « tools/gn/substitution_writer.cc ('k') | tools/gn/target.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698