third_party/WebKit/Source/core/layout/LayoutReplaced.h - Issue 1868013002: Percent height in auto height containers no longer computes as auto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutReplaced.h

Issue 1868013002: Percent height in auto height containers no longer computes as auto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@303728-6

Patch Set: Updated Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutReplaced.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutReplaced.h b/third_party/WebKit/Source/core/layout/LayoutReplaced.h

index 35ac0c378ccc6f9add3cd4aa337f0290daf3ea50..7706d56a6478bcaa25919eeda95b17a7475b4751 100644

--- a/third_party/WebKit/Source/core/layout/LayoutReplaced.h

+++ b/third_party/WebKit/Source/core/layout/LayoutReplaced.h

@@ -52,8 +52,8 @@ public:

LayoutReplaced(Element*, const LayoutSize& intrinsicSize);

~LayoutReplaced() override;

- LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred = ComputeActual) const override;

- LayoutUnit computeReplacedLogicalHeight() const override;

+ LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred = ComputeActual) const override;

+ LayoutUnit computeReplacedLogicalHeight(LayoutUnit estimatedUsedWidth = LayoutUnit()) const override;

bool hasReplacedLogicalHeight() const;

LayoutRect replacedContentRect(const LayoutSize* overriddenIntrinsicSize = nullptr) const;