Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 1868003004: Fix HttpStreamParser fuzzer. (Closed)

Created:
4 years, 8 months ago by mmenke
Modified:
4 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix HttpStreamParser fuzzer. Reading HTTP headers returns net::OK on some success paths, and bytes read on others. The test didn't account for this. This CL fixes the fuzzer to account for that. The weird HttpStreamParser behavior should also be fixed. BUG=598037 Committed: https://crrev.com/f344e9f0258f8d9f79b97f8ff445bb0d6fed1789 Cr-Commit-Position: refs/heads/master@{#386197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/http/http_stream_parser_fuzzer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
mmenke
Grumble...If only it were easy to run and debug these on Windows, I would have ...
4 years, 8 months ago (2016-04-08 20:19:39 UTC) #2
eroman
lgtm
4 years, 8 months ago (2016-04-08 20:58:59 UTC) #3
mmenke
On 2016/04/08 20:58:59, eroman wrote: > lgtm Thanks! Good thing fuzzers report code coverage, or ...
4 years, 8 months ago (2016-04-08 20:59:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868003004/1
4 years, 8 months ago (2016-04-08 21:00:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 21:06:16 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 21:08:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f344e9f0258f8d9f79b97f8ff445bb0d6fed1789
Cr-Commit-Position: refs/heads/master@{#386197}

Powered by Google App Engine
This is Rietveld 408576698