Preserving first/middle/last names when an Autofill profile is submitted

components/autofill/core/browser/autofill_data_util.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_data_util.h"
 
 #include <vector>
 
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "components/autofill/core/browser/field_types.h"
 
 namespace autofill {
 namespace data_util {
 
 namespace {
 const char* const name_prefixes[] = {
     "1lt",     "1st", "2lt", "2nd",    "3rd",  "admiral", "capt",
     "captain", "col", "cpt", "dr",     "gen",  "general", "lcdr",
     "lt",      "ltc", "ltg", "ltjg",   "maj",  "major",   "mg",
     "mr",      "mrs", "ms",  "pastor", "prof", "rep",     "reverend",
@@ skipping 44 matching lines @@
 void StripSuffixes(std::vector<base::string16>* name_tokens) {
   while (!name_tokens->empty()) {
     if (!ContainsString(name_suffixes, arraysize(name_suffixes),
                         name_tokens->back())) {
       break;
     }
     name_tokens->pop_back();
   }
 }
 
+// Concatenates two strings, adding a space and, optionally, a period.
+base::string16 StringConcatenationHelper(base::string16 first,
+                                         base::string16 second,
+                                         bool period) {
+  base::string16 delimiter =
+      period ? base::UTF8ToUTF16(". ") : base::UTF8ToUTF16(" ");
+  return first + delimiter + second;
+}
+
 }  // namespace
 
 NameParts SplitName(const base::string16& name) {
   std::vector<base::string16> name_tokens =
       base::SplitString(name, base::ASCIIToUTF16(" ,"), base::KEEP_WHITESPACE,
                         base::SPLIT_WANT_NONEMPTY);
   StripPrefixes(&name_tokens);
 
   // Don't assume "Ma" is a suffix in John Ma.
   if (name_tokens.size() > 2)
@@ skipping 35 matching lines @@
     parts.middle = name_tokens.back();
     name_tokens.pop_back();
   }
 
   // Remainder is given name.
   parts.given = base::JoinString(name_tokens, base::ASCIIToUTF16(" "));
 
   return parts;
 }
 
+bool ProfileMatchesFullName(const base::string16 full_name,
+                            const autofill::AutofillProfile& profile) {
+  // First Last
+  base::string16 candidate =
+      StringConcatenationHelper(profile.GetRawInfo(autofill::NAME_FIRST),

[Mathieu, 2016/04/13 18:12:24]

Not sure this StringConcatenationHelper is helping. 

static const base::string16 kSpace(" ");
static const base::string16 kPeriodSpace(". ");
...
candidate = profile.GetRawInfo(autofill::NAME_FIRST) + kSpace +
profile.GetRawInfo(autofill::NAME_MIDDLE);

is clearer IMO

[tmartino, 2016/04/13 19:43:25]

Agreed.

+                                profile.GetRawInfo(autofill::NAME_LAST), false);
+  if (!full_name.compare(candidate)) {
+    return true;
+  }
+
+  // First Middle Last
+  candidate = StringConcatenationHelper(
+      StringConcatenationHelper(profile.GetRawInfo(autofill::NAME_FIRST),
+                                profile.GetRawInfo(autofill::NAME_MIDDLE),
+                                false),
+      profile.GetRawInfo(autofill::NAME_LAST), false);
+  if (!full_name.compare(candidate)) {
+    return true;
+  }
+
+  // First M Last
+  candidate = StringConcatenationHelper(
+      StringConcatenationHelper(
+          profile.GetRawInfo(autofill::NAME_FIRST),
+          profile.GetRawInfo(autofill::NAME_MIDDLE_INITIAL), false),
+      profile.GetRawInfo(autofill::NAME_LAST), false);
+  if (!full_name.compare(candidate)) {
+    return true;
+  }
+
+  // First M. Last
+  candidate = StringConcatenationHelper(
+      StringConcatenationHelper(
+          profile.GetRawInfo(autofill::NAME_FIRST),
+          profile.GetRawInfo(autofill::NAME_MIDDLE_INITIAL), false),
+      profile.GetRawInfo(autofill::NAME_LAST), true);
+  if (!full_name.compare(candidate)) {
+    return true;
+  }
+
+  return false;
+}
+
 }  // namespace data_util
 }  // namespace autofill