Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2573)

Unified Diff: cc/layers/layer_impl.cc

Issue 1868003002: cc: Move RenderTarget Information to Effect Tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/layers/nine_patch_layer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer_impl.cc
diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc
index 3c41b1832c7d6e35b48cd6b1a45f31e16bac15fa..3a868928bf2bf4f71e5522f1b7c8a86150f0b8f7 100644
--- a/cc/layers/layer_impl.cc
+++ b/cc/layers/layer_impl.cc
@@ -276,7 +276,8 @@ void LayerImpl::TakeCopyRequestsAndTransformToTarget(
std::vector<scoped_ptr<CopyOutputRequest>>* requests) {
DCHECK(!copy_requests_.empty());
DCHECK(layer_tree_impl()->IsActiveTree());
- DCHECK_EQ(render_target(), this);
+ DCHECK(has_render_surface());
+ DCHECK_EQ(render_target(), render_surface());
size_t first_inserted_request = requests->size();
for (auto& request : copy_requests_)
@@ -1574,6 +1575,27 @@ gfx::Rect LayerImpl::GetScaledEnclosingRectInTargetSpace(float scale) const {
gfx::Rect(scaled_bounds));
}
+RenderSurfaceImpl* LayerImpl::render_target() {
+ EffectTree& effect_tree = layer_tree_impl_->property_trees()->effect_tree;
+ EffectNode* node = effect_tree.Node(effect_tree_index_);
+
+ if (node->data.render_surface)
+ return node->data.render_surface;
+ else
+ return effect_tree.Node(node->data.target_id)->data.render_surface;
+}
+
+const RenderSurfaceImpl* LayerImpl::render_target() const {
+ const EffectTree& effect_tree =
+ layer_tree_impl_->property_trees()->effect_tree;
+ const EffectNode* node = effect_tree.Node(effect_tree_index_);
+
+ if (node->data.render_surface)
+ return node->data.render_surface;
+ else
+ return effect_tree.Node(node->data.target_id)->data.render_surface;
+}
+
bool LayerImpl::IsHidden() const {
EffectTree& effect_tree = layer_tree_impl_->property_trees()->effect_tree;
EffectNode* node = effect_tree.Node(effect_tree_index_);
@@ -1586,14 +1608,12 @@ bool LayerImpl::InsideReplica() const {
EffectTree& effect_tree = layer_tree_impl_->property_trees()->effect_tree;
EffectNode* node = effect_tree.Node(effect_tree_index_);
- while (node) {
- EffectNode* target_node = effect_tree.Node(node->data.target_id);
- LayerImpl* target_layer =
- layer_tree_impl()->LayerById(target_node->owner_id);
+ while (node->id > 0) {
+ LayerImpl* target_layer = layer_tree_impl()->LayerById(node->owner_id);
DCHECK(target_layer);
if (target_layer->has_replica())
return true;
- node = effect_tree.parent(target_node);
+ node = effect_tree.Node(node->data.target_id);
}
return false;
« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/layers/nine_patch_layer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698