Flip Linux ChromeOS trybot to GN

Flip Linux ChromeOS trybot to GN

This flips linux_chromium_chromeos_compile_rel_ng.

Committed: https://crrev.com/6df3e8c400d8237cfc79006add26ce05f43bb9bf
Cr-Commit-Position: refs/heads/master@{#387423}

[brettw, 2016-04-07 23:20:15]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-08 00:11:11]

lgtm, if you can make the bots green.

[brettw, 2016-04-08 16:58:33]

This is failing because the aura_builder target doesn't exist. There are a bunch
of targets in all.gyp including that and things like chromium_builder_dbg that
appear to correspond to bots and have no GN analog. Should I make this target,
or is there something else that needs to be done?

[Dirk Pranke, 2016-04-08 18:00:32]

On 2016/04/08 16:58:33, brettw wrote:
> This is failing because the aura_builder target doesn't exist. There are a
bunch
> of targets in all.gyp including that and things like chromium_builder_dbg that
> appear to correspond to bots and have no GN analog. Should I make this target,
> or is there something else that needs to be done?

The answer isn't simple.

In theory, I've been trying to move away from the "group of random targets used
by a builder" model that we had,
and we should either be automatically only building the targets needed to run
tests (or explicitly configured),
or building everything.

However, there's a lot of stale configuration stuff in infra.

So, you could figure out where "aura_builder" is specified, see if it is covered
by all of the other
binaries needed to run the tests, add additional_compile_targets in
//testing/buildbot/*.json to make up
the difference, and then delete the 'aura_builder' entry from the bot configs.

Or, you could just add the target and call it a day.

The former is the right thing to do, but more work.

[brettw, 2016-04-08 20:25:52]

I don't think it's worth my time to go poking around the infra repo. I'll file a
bug with all the info here and then link it from a temporary aura_builder group
I make.

[brettw, 2016-04-12 00:19:28]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-04-12 00:19:29]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1867983002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-04-12 00:20:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867983002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867983002/80001

[commit-bot: I haz the power, 2016-04-12 00:42:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 00:42:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-04-12 16:48:09]

To record what's going on: I can't reproduce the NVCtrl.c error locally. But it
seems to be a difference in X headers. On my system I have this declaration:
  extern XExtDisplayInfo *XextAddDisplay(
    XExtensionInfo*	/* extinfo */,
    Display*		/* dpy */,
    _Xconst char*	/* ext_name */,  <------ Note const
    XExtensionHooks*	/* hooks */,
    int			/* nevents */,
    XPointer		/* data */
  );

But I can find versions of this header floating around like
http://osxr.org:8080/android/source/external/qemu/distrib/sdl-1.2.12/src/vide...
that don't have a const on the ext_name which will give this error.

I suspect GYP isn't compiling this target in this configuration, I'll try to
track that down.

[brettw, 2016-04-12 22:04:45]

Requires this angle change to land and roll in:
https://chromium-review.googlesource.com/#/c/338424/2

[brettw, 2016-04-14 00:41:18]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-04-14 00:41:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1867983002/#ps160001
(title: " ")

[commit-bot: I haz the power, 2016-04-14 00:41:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867983002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867983002/160001

[commit-bot: I haz the power, 2016-04-14 00:53:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 00:53:08]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[brettw, 2016-04-14 00:55:22]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-04-14 00:55:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867983002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867983002/160001

[commit-bot: I haz the power, 2016-04-14 03:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 03:25:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-04-14 15:55:30]

Description was changed from

==========
Flip Linux ChromeOS trybots to GN

This flips linux_chromium_chromeos_compile_rel_ng and
linux_chromium_chromeos_rel_ng.
==========

to

==========
Flip Linux ChromeOS trybot to GN

This flips linux_chromium_chromeos_compile_rel_ng.
==========

[brettw, 2016-04-14 15:55:56]

only one

[brettw, 2016-04-14 15:55:56]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-04-14 15:55:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1867983002/#ps180001
(title: "only one")

[commit-bot: I haz the power, 2016-04-14 15:56:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867983002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867983002/180001

[brettw, 2016-04-14 15:56:20]

There are some data files required for the non-compile-only bot, so I'm only
flipping the compile bot in this patch.

[Dirk Pranke, 2016-04-14 16:20:46]

still lgtm.

[commit-bot: I haz the power, 2016-04-14 19:58:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 19:58:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-04-14 20:07:27]

fix

[brettw, 2016-04-14 20:07:28]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-04-14 20:07:29]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1867983002/#ps200001
(title: "fix")

[commit-bot: I haz the power, 2016-04-14 20:07:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867983002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867983002/200001

[commit-bot: I haz the power, 2016-04-14 21:07:21]

Description was changed from

==========
Flip Linux ChromeOS trybot to GN

This flips linux_chromium_chromeos_compile_rel_ng.
==========

to

==========
Flip Linux ChromeOS trybot to GN

This flips linux_chromium_chromeos_compile_rel_ng.
==========

[commit-bot: I haz the power, 2016-04-14 21:07:23]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-04-14 21:09:13]

Description was changed from

==========
Flip Linux ChromeOS trybot to GN

This flips linux_chromium_chromeos_compile_rel_ng.
==========

to

==========
Flip Linux ChromeOS trybot to GN

This flips linux_chromium_chromeos_compile_rel_ng.

Committed: https://crrev.com/6df3e8c400d8237cfc79006add26ce05f43bb9bf
Cr-Commit-Position: refs/heads/master@{#387423}
==========

[commit-bot: I haz the power, 2016-04-14 21:09:14]

Patchset 11 (id:??) landed as
https://crrev.com/6df3e8c400d8237cfc79006add26ce05f43bb9bf
Cr-Commit-Position: refs/heads/master@{#387423}