Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1867963003: Add PopulateKey method to datastore. (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add PopulateKey method to datastore. Add PopulateKey, a method that, given an object, fills in its key fields. Fixes #44. BUG= Committed: https://github.com/luci/gae/commit/6f2456b4ce69df457abfa02313a8ee3d9f2c1b16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -20 lines) Patch
M pre-commit-go.yml View 1 chunk +1 line, -1 line 0 comments Download
M service/datastore/datastore.go View 1 chunk +20 lines, -0 lines 0 comments Download
M service/datastore/datastore_test.go View 2 chunks +38 lines, -0 lines 0 comments Download
M service/datastore/multiarg.go View 6 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
PTAL
4 years, 8 months ago (2016-04-07 22:58:42 UTC) #2
iannucci
lgtm
4 years, 8 months ago (2016-04-07 23:26:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867963003/1
4 years, 8 months ago (2016-04-07 23:26:34 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 23:31:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/6f2456b4ce69df457abfa02313a8ee3d9f2c1b16

Powered by Google App Engine
This is Rietveld 408576698