Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1867963002: 🏃 Port to GN args from build/features.gypi (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
jbudorick, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Port to GN args from build/features.gypi Aside from v8_imminent_deprecation_warnings, all of these existed already but were not configurable as GN args. BUG=chromium:542853 LOG=n Committed: https://crrev.com/3ad450bc47cae890a13576d73ea41a2395e730b6 Cr-Commit-Position: refs/heads/master@{#35362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -20 lines) Patch
M BUILD.gn View 2 chunks +46 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
ptal
4 years, 8 months ago (2016-04-07 19:33:08 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-08 02:20:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867963002/1
4 years, 8 months ago (2016-04-08 13:42:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 14:16:55 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 14:17:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ad450bc47cae890a13576d73ea41a2395e730b6
Cr-Commit-Position: refs/heads/master@{#35362}

Powered by Google App Engine
This is Rietveld 408576698