Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1867953002:
This will disable the behavior on Windows 10 in which (Closed)
DescriptionThis will disable the behavior on Windows 10 in which
touchpad scrolling on Windows 10 will also activate/focus
the window.
BUG=601116
Committed: https://crrev.com/0b272b68a3aaf908a4300326290d6f04efb838ba
Cr-Commit-Position: refs/heads/master@{#386718}
Patch Set 1 #Patch Set 2 : Need to ensure this builds an runs on Windows 7, so remove implicit linkage to GetPointerType() #
Total comments: 4
Patch Set 3 : Updates based on CL comments #
Total comments: 10
Patch Set 4 : Updates based on CL feedback. #
Messages
Total messages: 22 (9 generated)
Description was changed from ========== This will disable the behavior on Windows 10 in which touchpad scrolling on Windows 10 will also activate/focus the window. BUG=601116 ========== to ========== This will disable the behavior on Windows 10 in which touchpad scrolling on Windows 10 will also activate/focus the window. BUG=601116 ==========
kylixrd@chromium.org changed reviewers: + ananta@chromium.org
Latest patch now builds for all Windows versions.
https://codereview.chromium.org/1867953002/diff/20001/ui/views/win/hwnd_messa... File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/1867953002/diff/20001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1567: typedef BOOL (WINAPI *GetPointerTypeFn)(UINT32, POINTER_INPUT_TYPE *); Please move this to the function. Perhaps use using here to declare the function pointer? https://codereview.chromium.org/1867953002/diff/20001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1586: SetMsgHandled(TRUE); You don't need to call SetMsgHandled(TRUE). That should be the default?
https://codereview.chromium.org/1867953002/diff/20001/ui/views/win/hwnd_messa... File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/1867953002/diff/20001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1567: typedef BOOL (WINAPI *GetPointerTypeFn)(UINT32, POINTER_INPUT_TYPE *); On 2016/04/11 21:51:08, ananta wrote: > Please move this to the function. Perhaps use using here to declare the function > pointer? Done. https://codereview.chromium.org/1867953002/diff/20001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1586: SetMsgHandled(TRUE); On 2016/04/11 21:51:08, ananta wrote: > You don't need to call SetMsgHandled(TRUE). That should be the default? Done.
iyengar@google.com changed reviewers: + iyengar@google.com
lgtm
kylixrd@chromium.org changed reviewers: - iyengar@google.com
lgtm
kylixrd@chromium.org changed reviewers: + sky@chromium.org
https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1578: typedef BOOL(WINAPI *GetPointerTypeFn)(UINT32, POINTER_INPUT_TYPE *); using? https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1579: UINT32 pointerId = GET_POINTERID_WPARAM(w_param); pointer_id https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1580: POINTER_INPUT_TYPE pointerType; pointer_type https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1582: GetProcAddress(GetModuleHandleA("user32.dll"), "GetPointerType")); make sure you run git cl format (I think this should be a 4 line indent, but I could be wrong). https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1584: if (pointerType == PT_TOUCHPAD) { Combine these into a single if statement.
https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1578: typedef BOOL(WINAPI *GetPointerTypeFn)(UINT32, POINTER_INPUT_TYPE *); On 2016/04/12 13:19:16, sky wrote: > using? Had to look that up... not quite fully up-to-speed on newer C++11 syntax. "using" is a way nicer syntax for function pointer decls. https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1579: UINT32 pointerId = GET_POINTERID_WPARAM(w_param); On 2016/04/12 13:19:16, sky wrote: > pointer_id Done. https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1580: POINTER_INPUT_TYPE pointerType; On 2016/04/12 13:19:16, sky wrote: > pointer_type Done. https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1582: GetProcAddress(GetModuleHandleA("user32.dll"), "GetPointerType")); On 2016/04/12 13:19:16, sky wrote: > make sure you run git cl format (I think this should be a 4 line indent, but I > could be wrong). Done. https://codereview.chromium.org/1867953002/diff/40001/ui/views/win/hwnd_messa... ui/views/win/hwnd_message_handler.cc:1584: if (pointerType == PT_TOUCHPAD) { On 2016/04/12 13:19:16, sky wrote: > Combine these into a single if statement. Done.
LGTM
The CQ bit was checked by kylixrd@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from iyengar@google.com, ananta@chromium.org Link to the patchset: https://codereview.chromium.org/1867953002/#ps60001 (title: "Updates based on CL feedback.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867953002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867953002/60001
Message was sent while issue was closed.
Description was changed from ========== This will disable the behavior on Windows 10 in which touchpad scrolling on Windows 10 will also activate/focus the window. BUG=601116 ========== to ========== This will disable the behavior on Windows 10 in which touchpad scrolling on Windows 10 will also activate/focus the window. BUG=601116 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== This will disable the behavior on Windows 10 in which touchpad scrolling on Windows 10 will also activate/focus the window. BUG=601116 ========== to ========== This will disable the behavior on Windows 10 in which touchpad scrolling on Windows 10 will also activate/focus the window. BUG=601116 Committed: https://crrev.com/0b272b68a3aaf908a4300326290d6f04efb838ba Cr-Commit-Position: refs/heads/master@{#386718} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0b272b68a3aaf908a4300326290d6f04efb838ba Cr-Commit-Position: refs/heads/master@{#386718} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
