Specialize instance calls when the call receiver is the method receiver and the method class has a …

Precompilation: Specialize instance calls when the call receiver is the method receiver and the method class has a small number of concrete subclasses (currently 5).

CompileOnceHelloHtml (ARMv7HF) +17.194%
DeltaBlueClosures (ARMv7HF) +28.379%
DeltaBlue (ARMv7HF) +30.190%

precompiled dart2js arm 19071745 -> 19504726 (+2.3%)

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/e048774776f20cf45edddf607a0c90abcb3ccd07

[rmacnak, 2016-04-07 23:50:15]

Description was changed from

==========
Specialize instance calls when the call receiver is the method receiver and the
method class has a small number of concrete subclasses (currently 5).
==========

to

==========
Precompilation: Specialize instance calls when the call receiver is the method
receiver and the method class has a small number of concrete subclasses
(currently 5).
==========

[rmacnak, 2016-04-08 00:52:50]

Description was changed from

==========
Precompilation: Specialize instance calls when the call receiver is the method
receiver and the method class has a small number of concrete subclasses
(currently 5).
==========

to

==========
Precompilation: Specialize instance calls when the call receiver is the method
receiver and the method class has a small number of concrete subclasses
(currently 5).

CompileOnceHelloHtml (ARMv7HF) +17.194%
DeltaBlueClosures (ARMv7HF) +28.379%
DeltaBlue (ARMv7HF) +30.190%

precompiled dart2js arm 19056640 -> 19726958 (+3.5%)
==========

[rmacnak, 2016-04-08 00:54:41]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[rmacnak, 2016-04-08 00:54:42]

http://146.148.43.81:8080/Comparison#targetA%3Ddart-unopt%3BmachineTypeA%3Dli...

[Florian Schneider, 2016-04-08 22:39:38]

lgtm

https://codereview.chromium.org/1867913004/diff/20001/runtime/vm/aot_optimize...
File runtime/vm/aot_optimizer.cc (right):

https://codereview.chromium.org/1867913004/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:289: with_checks,
for style consistency:

/* with_checks = */ false
/* complete = */ false

https://codereview.chromium.org/1867913004/diff/20001/runtime/vm/flow_graph_i...
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/1867913004/diff/20001/runtime/vm/flow_graph_i...
runtime/vm/flow_graph_inliner.cc:1782: call_->complete());  // Complete.
This call could avoid the slow path code if you change
FlowGraphCompiler::EmitPolymorphicInstanceCall and EmitTestAndCall to check if
'complete' is true.

[rmacnak, 2016-04-11 17:20:23]

Changed EmitTestAndCall to avoid the last comparison and generation of slow path
with the cases are exhaustive. PTAL

https://codereview.chromium.org/1867913004/diff/20001/runtime/vm/aot_optimize...
File runtime/vm/aot_optimizer.cc (right):

https://codereview.chromium.org/1867913004/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:289: with_checks,
On 2016/04/08 22:39:38, Florian Schneider wrote:
> for style consistency:
> 
> /* with_checks = */ false
> /* complete = */ false

Done.

[Florian Schneider, 2016-04-11 17:42:25]

LGTM

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/aot_optimize...
File runtime/vm/aot_optimizer.cc (right):

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2572: PolymorphicInstanceCallInstr* call =
Could you change IL printing for PolymorphicInstanceCallInstr so that we can see
with_checks and is_complete when printing the flow graph, i.e. without printing
disassembly?

[srdjan, 2016-04-11 18:10:42]

srdjan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2016-04-11 18:10:42]

DBC

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/aot_optimize...
File runtime/vm/aot_optimizer.cc (right):

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2534: if (class_ids.length() <= 5) {
How about parametrizing 5 (with a flag), or at least a constant.

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/cha.h
File runtime/vm/cha.h (right):

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/cha.h#newcode38
runtime/vm/cha.h:38: bool ConcreteSubclasses(const Class& cls,
GrowableArray<intptr_t> *class_ids);
Please add a comment what this method does.

[rmacnak, 2016-04-11 19:32:18]

Description was changed from

==========
Precompilation: Specialize instance calls when the call receiver is the method
receiver and the method class has a small number of concrete subclasses
(currently 5).

CompileOnceHelloHtml (ARMv7HF) +17.194%
DeltaBlueClosures (ARMv7HF) +28.379%
DeltaBlue (ARMv7HF) +30.190%

precompiled dart2js arm 19056640 -> 19726958 (+3.5%)
==========

to

==========
Precompilation: Specialize instance calls when the call receiver is the method
receiver and the method class has a small number of concrete subclasses
(currently 5).

CompileOnceHelloHtml (ARMv7HF) +17.194%
DeltaBlueClosures (ARMv7HF) +28.379%
DeltaBlue (ARMv7HF) +30.190%

precompiled dart2js arm 19071745 -> 19504726 (+2.3%)
==========

[rmacnak, 2016-04-11 19:33:42]

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/aot_optimize...
File runtime/vm/aot_optimizer.cc (right):

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2534: if (class_ids.length() <= 5) {
On 2016/04/11 18:10:42, srdjan wrote:
> How about parametrizing 5 (with a flag), or at least a constant.

Added FLAG_max_exhaustive_polymorphic_checks

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2572: PolymorphicInstanceCallInstr* call =
On 2016/04/11 17:42:25, Florian Schneider wrote:
> Could you change IL printing for PolymorphicInstanceCallInstr so that we can
see
> with_checks and is_complete when printing the flow graph, i.e. without
printing
> disassembly?

Done.

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/cha.h
File runtime/vm/cha.h (right):

https://codereview.chromium.org/1867913004/diff/40001/runtime/vm/cha.h#newcode38
runtime/vm/cha.h:38: bool ConcreteSubclasses(const Class& cls,
GrowableArray<intptr_t> *class_ids);
On 2016/04/11 18:10:42, srdjan wrote:
> Please add a comment what this method does.

Done.

[rmacnak, 2016-04-11 19:52:31]

Description was changed from

==========
Precompilation: Specialize instance calls when the call receiver is the method
receiver and the method class has a small number of concrete subclasses
(currently 5).

CompileOnceHelloHtml (ARMv7HF) +17.194%
DeltaBlueClosures (ARMv7HF) +28.379%
DeltaBlue (ARMv7HF) +30.190%

precompiled dart2js arm 19071745 -> 19504726 (+2.3%)
==========

to

==========
Precompilation: Specialize instance calls when the call receiver is the method
receiver and the method class has a small number of concrete subclasses
(currently 5).

CompileOnceHelloHtml (ARMv7HF) +17.194%
DeltaBlueClosures (ARMv7HF) +28.379%
DeltaBlue (ARMv7HF) +30.190%

precompiled dart2js arm 19071745 -> 19504726 (+2.3%)

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e048774776f20cf45edddf607a0c90abcb3ccd07
==========

[rmacnak, 2016-04-11 19:52:33]

Committed patchset #4 (id:60001) manually as
e048774776f20cf45edddf607a0c90abcb3ccd07 (presubmit successful).