Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2388)

Unified Diff: cc/output/filter_operations_unittest.cc

Issue 1867913002: Implement cc::FilterOperations::MapRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: senorblanco review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/filter_operations.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/filter_operations_unittest.cc
diff --git a/cc/output/filter_operations_unittest.cc b/cc/output/filter_operations_unittest.cc
index 05c0289ea9f3b7af83a016efb97b93d841c45531..7b2fa1a8677d14a0d2303a9a12b9337207f5d046 100644
--- a/cc/output/filter_operations_unittest.cc
+++ b/cc/output/filter_operations_unittest.cc
@@ -9,7 +9,9 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/effects/SkBlurImageFilter.h"
#include "third_party/skia/include/effects/SkDropShadowImageFilter.h"
+#include "third_party/skia/include/effects/SkOffsetImageFilter.h"
#include "ui/gfx/geometry/point.h"
+#include "ui/gfx/geometry/rect.h"
namespace cc {
namespace {
@@ -26,6 +28,13 @@ TEST(FilterOperationsTest, GetOutsetsBlur) {
EXPECT_EQ(57, left);
}
+TEST(FilterOperationsTest, MapRectBlur) {
+ FilterOperations ops;
+ ops.Append(FilterOperation::CreateBlurFilter(20));
+ EXPECT_EQ(gfx::Rect(-57, -57, 124, 124),
+ ops.MapRect(gfx::Rect(0, 0, 10, 10)));
+}
+
TEST(FilterOperationsTest, GetOutsetsDropShadowReferenceFilter) {
// TODO(hendrikw): We need to make outsets for reference filters be in line
// with non-reference filters. See crbug.com/523534
@@ -46,6 +55,25 @@ TEST(FilterOperationsTest, GetOutsetsDropShadowReferenceFilter) {
EXPECT_EQ(15, left);
}
+TEST(FilterOperationsTest, MapRectDropShadowReferenceFilter) {
+ skia::RefPtr<SkImageFilter> filter =
+ skia::AdoptRef(SkDropShadowImageFilter::Create(
+ SkIntToScalar(3), SkIntToScalar(8), SkIntToScalar(4),
+ SkIntToScalar(9), SK_ColorBLACK,
+ SkDropShadowImageFilter::kDrawShadowAndForeground_ShadowMode));
+ FilterOperations ops;
+ ops.Append(FilterOperation::CreateReferenceFilter(filter));
+ EXPECT_EQ(gfx::Rect(-9, -19, 34, 64), ops.MapRect(gfx::Rect(0, 0, 10, 10)));
+}
+
+TEST(FilterOperationsTest, MapRectOffsetReferenceFilter) {
+ skia::RefPtr<SkImageFilter> filter =
+ skia::AdoptRef(SkOffsetImageFilter::Make(30, 40, nullptr));
+ FilterOperations ops;
+ ops.Append(FilterOperation::CreateReferenceFilter(std::move(filter)));
+ EXPECT_EQ(gfx::Rect(30, 40, 10, 10), ops.MapRect(gfx::Rect(0, 0, 10, 10)));
+}
+
TEST(FilterOperationsTest, GetOutsetsNullReferenceFilter) {
FilterOperations ops;
ops.Append(FilterOperation::CreateReferenceFilter(nullptr));
@@ -59,6 +87,12 @@ TEST(FilterOperationsTest, GetOutsetsNullReferenceFilter) {
EXPECT_EQ(0, left);
}
+TEST(FilterOperationsTest, MapRectNullReferenceFilter) {
+ FilterOperations ops;
+ ops.Append(FilterOperation::CreateReferenceFilter(nullptr));
+ EXPECT_EQ(gfx::Rect(0, 0, 10, 10), ops.MapRect(gfx::Rect(0, 0, 10, 10)));
+}
+
TEST(FilterOperationsTest, GetOutsetsDropShadow) {
FilterOperations ops;
ops.Append(FilterOperation::CreateDropShadowFilter(gfx::Point(3, 8), 20, 0));
@@ -71,6 +105,13 @@ TEST(FilterOperationsTest, GetOutsetsDropShadow) {
EXPECT_EQ(54, left);
}
+TEST(FilterOperationsTest, MapRectDropShadow) {
+ FilterOperations ops;
+ ops.Append(FilterOperation::CreateDropShadowFilter(gfx::Point(3, 8), 20, 0));
+ EXPECT_EQ(gfx::Rect(-54, -49, 124, 124),
+ ops.MapRect(gfx::Rect(0, 0, 10, 10)));
+}
+
#define SAVE_RESTORE_AMOUNT(filter_name, filter_type, a) \
{ \
FilterOperation op = FilterOperation::Create##filter_name##Filter(a); \
« no previous file with comments | « cc/output/filter_operations.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698