src/gpu/vk/GrVkGpu.cpp - Issue 1867883002: Fix a bunch of memory issues in Vulkan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkGpu.cpp

Issue 1867883002: Fix a bunch of memory issues in Vulkan (Closed) Base URL: https://skia.googlesource.com/skia.git@vkValgrind

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/vk/GrVkGpu.cpp

diff --git a/src/gpu/vk/GrVkGpu.cpp b/src/gpu/vk/GrVkGpu.cpp

index e1e99ed0209b7be99cba0930fc73cb8d866a64ae..e2ec3781a31030489841a7974965a86dd4fba047 100644

--- a/src/gpu/vk/GrVkGpu.cpp

+++ b/src/gpu/vk/GrVkGpu.cpp

@@ -1209,15 +1209,18 @@ void GrVkGpu::copySurfaceAsBlit(GrSurface* dst,

// Flip rect if necessary

SkIRect srcVkRect;

+ srcVkRect.fLeft = srcRect.fLeft;

+ srcVkRect.fRight = srcRect.fRight;

SkIRect dstRect;

dstRect.fLeft = dstPoint.fX;

- dstRect.fRight = dstPoint.fX + srcVkRect.width();

+ dstRect.fRight = dstPoint.fX + srcRect.width();

jvanverth1 2016/04/07 17:03:54 whoops

if (kBottomLeft_GrSurfaceOrigin == src->origin()) {

srcVkRect.fTop = src->height() - srcRect.fBottom;

srcVkRect.fBottom = src->height() - srcRect.fTop;

} else {

- srcVkRect = srcRect;

+ srcVkRect.fTop = srcRect.fTop;

+ srcVkRect.fBottom = srcRect.fBottom;

}

if (kBottomLeft_GrSurfaceOrigin == dst->origin()) {

« no previous file with comments | « src/gpu/vk/GrVkExtensions.cpp ('k') | src/gpu/vk/GrVkPipelineState.cpp » ('j') | no next file with comments »