Fix a bunch of memory issues in Vulkan

src/gpu/vk/GrVkExtensions.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "vk/GrVkExtensions.h"
 #include "vk/GrVkUtil.h"
 
@@ skipping 35 matching lines @@
 
     // instance layers
     uint32_t layerCount = 0;
     VkResult res = EnumerateInstanceLayerProperties(&layerCount, nullptr);
     if (VK_SUCCESS != res) {
         return false;
     }
     VkLayerProperties* layers = new VkLayerProperties[layerCount];
     res = EnumerateInstanceLayerProperties(&layerCount, layers);
     if (VK_SUCCESS != res) {
+        delete[] layers;
         return false;
     }
     for (uint32_t i = 0; i < layerCount; ++i) {
         if (specVersion >= layers[i].specVersion) {
             fInstanceLayerStrings->push_back() = layers[i].layerName;
         }
     }
     delete[] layers;
     if (!fInstanceLayerStrings->empty()) {
         SkTQSort(&fInstanceLayerStrings->front(), &fInstanceLayerStrings->back(), cmp);
     }
 
     // instance extensions
     // via Vulkan implementation and implicitly enabled layers
     uint32_t extensionCount = 0;
     res = EnumerateInstanceExtensionProperties(nullptr, &extensionCount, nullptr);
     if (VK_SUCCESS != res) {
         return false;
     }
     VkExtensionProperties* extensions = new VkExtensionProperties[extensionCount];
     res = EnumerateInstanceExtensionProperties(nullptr, &extensionCount, extensions);
     if (VK_SUCCESS != res) {
+        delete[] extensions;
         return false;
     }
     for (uint32_t i = 0; i < extensionCount; ++i) {
         if (specVersion >= extensions[i].specVersion) {
             fInstanceExtensionStrings->push_back() = extensions[i].extensionName;
         }
     }
     delete [] extensions;
     // sort so we can search
     if (!fInstanceExtensionStrings->empty()) {
         SkTQSort(&fInstanceExtensionStrings->front(), &fInstanceExtensionStrings->back(), cmp);
     }
     // via explicitly enabled layers
     layerCount = fInstanceLayerStrings->count();
     for (uint32_t layerIndex = 0; layerIndex < layerCount; ++layerIndex) {
         uint32_t extensionCount = 0;
         res = EnumerateInstanceExtensionProperties((*fInstanceLayerStrings)[layerIndex].c_str(),
                                                    &extensionCount, nullptr);
         if (VK_SUCCESS != res) {
             return false;
         }
         VkExtensionProperties* extensions = new VkExtensionProperties[extensionCount];
         res = EnumerateInstanceExtensionProperties((*fInstanceLayerStrings)[layerIndex].c_str(),
                                                    &extensionCount, extensions);
         if (VK_SUCCESS != res) {
+            delete[] extensions;
             return false;
         }
         for (uint32_t i = 0; i < extensionCount; ++i) {
             // if not already in the list, add it
             if (specVersion >= extensions[i].specVersion &&
                 find_string(*fInstanceExtensionStrings, extensions[i].extensionName) < 0) {
                 fInstanceExtensionStrings->push_back() = extensions[i].extensionName;
                 SkTQSort(&fInstanceExtensionStrings->front(), &fInstanceExtensionStrings->back(),
                          cmp);
             }
@@ skipping 18 matching lines @@
 
     // device layers
     uint32_t layerCount = 0;
     VkResult res = EnumerateDeviceLayerProperties(physDev, &layerCount, nullptr);
     if (VK_SUCCESS != res) {
         return false;
     }
     VkLayerProperties* layers = new VkLayerProperties[layerCount];
     res = EnumerateDeviceLayerProperties(physDev, &layerCount, layers);
     if (VK_SUCCESS != res) {
+        delete[] layers;
         return false;
     }
     for (uint32_t i = 0; i < layerCount; ++i) {
         if (specVersion >= layers[i].specVersion) {
             fDeviceLayerStrings->push_back() = layers[i].layerName;
         }
     }
     delete[] layers;
     if (!fDeviceLayerStrings->empty()) {
         SkTLessFunctionToFunctorAdaptor<SkString, extension_compare> cmp;
         SkTQSort(&fDeviceLayerStrings->front(), &fDeviceLayerStrings->back(), cmp);
     }
 
     // device extensions
     // via Vulkan implementation and implicitly enabled layers
     uint32_t extensionCount = 0;
     res = EnumerateDeviceExtensionProperties(physDev, nullptr, &extensionCount, nullptr);
     if (VK_SUCCESS != res) {
         return false;
     }
     VkExtensionProperties* extensions = new VkExtensionProperties[extensionCount];
     res = EnumerateDeviceExtensionProperties(physDev, nullptr, &extensionCount, extensions);
     if (VK_SUCCESS != res) {
+        delete[] extensions;
         return false;
     }
     for (uint32_t i = 0; i < extensionCount; ++i) {
         if (specVersion >= extensions[i].specVersion) {
             fDeviceExtensionStrings->push_back() = extensions[i].extensionName;
         }
     }
     delete[] extensions;
     if (!fDeviceExtensionStrings->empty()) {
         SkTLessFunctionToFunctorAdaptor<SkString, extension_compare> cmp;
         SkTQSort(&fDeviceExtensionStrings->front(), &fDeviceExtensionStrings->back(), cmp);
     }
     // via explicitly enabled layers
     layerCount = fDeviceLayerStrings->count();
     for (uint32_t layerIndex = 0; layerIndex < layerCount; ++layerIndex) {
         uint32_t extensionCount = 0;
         res = EnumerateDeviceExtensionProperties(physDev,
             (*fDeviceLayerStrings)[layerIndex].c_str(),
             &extensionCount, nullptr);
         if (VK_SUCCESS != res) {
             return false;
         }
         VkExtensionProperties* extensions = new VkExtensionProperties[extensionCount];
         res = EnumerateDeviceExtensionProperties(physDev,
             (*fDeviceLayerStrings)[layerIndex].c_str(),
             &extensionCount, extensions);
         if (VK_SUCCESS != res) {
+            delete[] extensions;
             return false;
         }
         for (uint32_t i = 0; i < extensionCount; ++i) {
             // if not already in the list, add it
             if (specVersion >= extensions[i].specVersion &&
                 find_string(*fDeviceExtensionStrings, extensions[i].extensionName) < 0) {
                 fDeviceExtensionStrings->push_back() = extensions[i].extensionName;
                 SkTQSort(&fDeviceExtensionStrings->front(), &fDeviceExtensionStrings->back(), cmp);
             }
         }
@@ skipping 37 matching lines @@
     SkDebugf("\nInstance Layers: ");
     for (int i = 0; i < cnt; ++i) {
         SkDebugf("%s%s", (*fInstanceLayerStrings)[i].c_str(), (i < cnt - 1) ? sep : "");
     }
     cnt = fDeviceLayerStrings->count();
     SkDebugf("\nDevice Layers: ");
     for (int i = 0; i < cnt; ++i) {
         SkDebugf("%s%s", (*fDeviceLayerStrings)[i].c_str(), (i < cnt - 1) ? sep : "");
     }
 }