Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1867873002: Move unittests in content/common/gpu/client to gpu/ipc/client (Closed)

Created:
4 years, 8 months ago by Peng
Modified:
4 years, 8 months ago
Reviewers:
jam, no sievers, piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move unittests in content/common/gpu/client to gpu/ipc/client BUG=586380 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/c9c73f48e2737e2b1038eb14ab0c8f053fb3f251 Cr-Commit-Position: refs/heads/master@{#389823}

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Update #

Patch Set 4 : Update #

Patch Set 5 : Update #

Patch Set 6 : Update #

Patch Set 7 : Rebase #

Patch Set 8 : Update #

Patch Set 9 : Update #

Total comments: 2

Patch Set 10 : Rebase and update #

Patch Set 11 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -1218 lines) Patch
M .gn View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M build/all.gyp View 1 2 3 4 5 6 7 8 9 10 4 chunks +0 lines, -4 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 1 2 3 4 5 6 7 8 9 10 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/android/browser_surface_texture_manager.h View 1 2 3 4 5 2 chunks +2 lines, -12 lines 0 comments Download
M content/browser/android/browser_surface_texture_manager.cc View 1 2 3 4 5 1 chunk +0 lines, -16 lines 0 comments Download
D content/browser/android/in_process_surface_texture_manager.h View 1 2 3 4 5 6 1 chunk +0 lines, -59 lines 0 comments Download
D content/browser/android/in_process_surface_texture_manager.cc View 1 2 3 4 5 6 1 chunk +0 lines, -80 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 3 4 5 6 4 chunks +58 lines, -0 lines 0 comments Download
D content/common/gpu/client/gpu_context_tests.h View 1 chunk +0 lines, -138 lines 0 comments Download
D content/common/gpu/client/gpu_in_process_context_tests.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -62 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_surface_texture_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -2 lines 0 comments Download
D content/content_gl_tests.isolate View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -56 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 4 chunks +0 lines, -77 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -46 lines 0 comments Download
M content/test/content_test_suite.cc View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -2 lines 0 comments Download
M content/test/gpu/generate_buildbot_json.py View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
D content/test/run_all_gl_tests.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -39 lines 0 comments Download
M gpu/BUILD.gn View 1 2 3 4 5 6 7 8 9 4 chunks +16 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/unittest_main.cc View 1 2 3 4 5 1 chunk +38 lines, -1 line 0 comments Download
M gpu/gpu.gyp View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -2 lines 0 comments Download
M gpu/gpu_ipc_client.gypi View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/client/BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A + gpu/ipc/client/android/in_process_surface_texture_manager.h View 1 2 3 4 5 6 4 chunks +8 lines, -19 lines 0 comments Download
A + gpu/ipc/client/android/in_process_surface_texture_manager.cc View 1 2 3 4 5 6 3 chunks +5 lines, -25 lines 0 comments Download
A + gpu/ipc/client/gpu_context_tests.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/ipc/client/gpu_in_process_context_tests.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_surface_texture_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 1 2 3 4 5 6 7 8 9 10 9 chunks +0 lines, -146 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 2 3 4 5 6 7 8 9 10 25 chunks +0 lines, -402 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -5 lines 0 comments Download
M testing/buildbot/manage.py View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (11 generated)
Peng
hi piman, PTAL. Thanks.
4 years, 8 months ago (2016-04-12 17:45:36 UTC) #4
piman
https://codereview.chromium.org/1867873002/diff/160001/content/browser/android/browser_surface_texture_manager.h File content/browser/android/browser_surface_texture_manager.h (left): https://codereview.chromium.org/1867873002/diff/160001/content/browser/android/browser_surface_texture_manager.h#oldcode19 content/browser/android/browser_surface_texture_manager.h:19: public gpu::SurfaceTexturePeer { This change and many others in ...
4 years, 8 months ago (2016-04-14 01:31:04 UTC) #5
Peng
https://codereview.chromium.org/1867873002/diff/160001/content/browser/android/browser_surface_texture_manager.h File content/browser/android/browser_surface_texture_manager.h (left): https://codereview.chromium.org/1867873002/diff/160001/content/browser/android/browser_surface_texture_manager.h#oldcode19 content/browser/android/browser_surface_texture_manager.h:19: public gpu::SurfaceTexturePeer { On 2016/04/14 01:31:04, piman wrote: > ...
4 years, 8 months ago (2016-04-14 15:06:52 UTC) #6
piman
+sievers, could you take look at the android bits? You're more familiar with it than ...
4 years, 8 months ago (2016-04-14 22:10:53 UTC) #8
Peng
On 2016/04/14 22:10:53, piman wrote: > +sievers, could you take look at the android bits? ...
4 years, 8 months ago (2016-04-25 20:46:24 UTC) #9
no sievers
On 2016/04/25 20:46:24, Peng wrote: > On 2016/04/14 22:10:53, piman wrote: > > +sievers, could ...
4 years, 8 months ago (2016-04-25 23:03:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867873002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867873002/160001
4 years, 8 months ago (2016-04-26 14:13:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/25071) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-26 14:15:22 UTC) #14
Peng
+jam for .gn, BUILD.gn, testing/* and build/* hi John, PTAL. Thanks.
4 years, 8 months ago (2016-04-26 15:55:50 UTC) #16
jam
lgtm
4 years, 8 months ago (2016-04-26 16:28:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867873002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867873002/200001
4 years, 8 months ago (2016-04-26 17:46:08 UTC) #20
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 8 months ago (2016-04-26 18:52:31 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 18:54:08 UTC) #24
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/c9c73f48e2737e2b1038eb14ab0c8f053fb3f251
Cr-Commit-Position: refs/heads/master@{#389823}

Powered by Google App Engine
This is Rietveld 408576698