Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1867863002: Convert SkRefCnt to std::atomic. (Closed)

Created:
4 years, 8 months ago by bungeman-skia
Modified:
4 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert SkRefCnt to std::atomic. This enables removing the more complicated atomic shims from SkAtomics.h. TBR=reed This doesn't actually change any API. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot Committed: https://skia.googlesource.com/skia/+/2c4bd0798e929acb9663668985eabe74d7378c46

Patch Set 1 #

Patch Set 2 : Just convert ref counting. #

Patch Set 3 : Another missing include. #

Patch Set 4 : Clean up the rest. #

Patch Set 5 : Only verify weak count in debug. #

Total comments: 2

Patch Set 6 : Use the members. #

Patch Set 7 : Restore to 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -79 lines) Patch
M include/core/SkPathRef.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkRefCnt.h View 1 2 3 4 5 6 7 chunks +31 lines, -25 lines 0 comments Download
M include/private/SkAtomics.h View 1 chunk +0 lines, -28 lines 0 comments Download
M include/private/SkOnce.h View 1 chunk +1 line, -1 line 0 comments Download
M include/private/SkWeakRefCnt.h View 1 2 3 4 5 7 chunks +38 lines, -22 lines 0 comments Download
M src/core/SkRWBuffer.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tests/RefCntTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/TLSTest.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 41 (22 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867863002/1
4 years, 8 months ago (2016-04-07 15:55:52 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/6929)
4 years, 8 months ago (2016-04-07 15:57:01 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867863002/20001
4 years, 8 months ago (2016-04-07 18:03:45 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/7666)
4 years, 8 months ago (2016-04-07 18:10:19 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867863002/40001
4 years, 8 months ago (2016-04-07 18:42:55 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867863002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867863002/60001
4 years, 8 months ago (2016-04-07 19:41:15 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/7671)
4 years, 8 months ago (2016-04-07 19:43:07 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867863002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867863002/80001
4 years, 8 months ago (2016-04-07 19:50:15 UTC) #19
bungeman-skia
Because eventually it should be done.
4 years, 8 months ago (2016-04-07 20:17:07 UTC) #21
bungeman-skia
4 years, 8 months ago (2016-04-07 20:19:35 UTC) #23
mtklein
lgtm either way https://codereview.chromium.org/1867863002/diff/80001/include/core/SkRefCnt.h File include/core/SkRefCnt.h (right): https://codereview.chromium.org/1867863002/diff/80001/include/core/SkRefCnt.h#newcode42 include/core/SkRefCnt.h:42: std::atomic_store_explicit(&fRefCnt, 0, std::memory_order_relaxed); Any reason to ...
4 years, 8 months ago (2016-04-07 21:44:49 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot on client.skia (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-07 21:50:45 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867863002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867863002/100001
4 years, 8 months ago (2016-04-07 22:39:20 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/7692)
4 years, 8 months ago (2016-04-07 22:41:31 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867863002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867863002/120001
4 years, 8 months ago (2016-04-07 22:47:20 UTC) #32
bungeman-skia
https://codereview.chromium.org/1867863002/diff/80001/include/core/SkRefCnt.h File include/core/SkRefCnt.h (right): https://codereview.chromium.org/1867863002/diff/80001/include/core/SkRefCnt.h#newcode42 include/core/SkRefCnt.h:42: std::atomic_store_explicit(&fRefCnt, 0, std::memory_order_relaxed); On 2016/04/07 21:44:49, mtklein wrote: > ...
4 years, 8 months ago (2016-04-07 22:49:35 UTC) #33
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot on client.skia (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-08 00:47:47 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867863002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867863002/120001
4 years, 8 months ago (2016-04-08 13:57:57 UTC) #39
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 13:58:55 UTC) #41
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/2c4bd0798e929acb9663668985eabe74d7378c46

Powered by Google App Engine
This is Rietveld 408576698