Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1867843003: Revert of Revert "Add (another) argument to break git locks in gclient." (Closed)

Created:
4 years, 8 months ago by iannucci
Modified:
4 years, 8 months ago
Reviewers:
dpranke, estaab, pgervais, smut
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Revert "Add (another) argument to break git locks in gclient." (patchset #1 id:1 of https://codereview.chromium.org/1865403003/ ) Reason for revert: This revert breaks /everything/ Original issue's description: > Revert "Add (another) argument to break git locks in gclient." > > This reverts commit 51797b1d8f24a26aa7f9c23212e06ed2b6cfc0e9. > > BUG=601564 > TBR=iannucci,dpranke,estaab,pgervais > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299771 TBR=dpranke@google.com,estaab@chromium.org,pgervais@chromium.org,smut@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601564 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M gclient.py View 1 chunk +5 lines, -0 lines 0 comments Download
M gclient_scm.py View 2 chunks +23 lines, -0 lines 0 comments Download
M tests/gclient_scm_test.py View 3 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
iannucci
Created Revert of Revert "Add (another) argument to break git locks in gclient."
4 years, 8 months ago (2016-04-07 21:35:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867843003/1
4 years, 8 months ago (2016-04-07 21:35:12 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:35:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299773

Powered by Google App Engine
This is Rietveld 408576698