Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: testing/libfuzzer/tests/fuzzer_launcher_test.cc

Issue 1867833002: [libfuzzer] store custom options in .GN build target instead of a separate file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update reference.md of libFuzzer & CF documentation. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/libfuzzer/tests/fuzzer_config_only_test.options ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/libfuzzer/tests/fuzzer_launcher_test.cc
diff --git a/testing/libfuzzer/tests/fuzzer_launcher_test.cc b/testing/libfuzzer/tests/fuzzer_launcher_test.cc
index 6ab3a38657fd312a88a3d88f6f10d7f942b2b2c7..5c9a3e1b1263cee66b87fde6f925897f019eeadd 100644
--- a/testing/libfuzzer/tests/fuzzer_launcher_test.cc
+++ b/testing/libfuzzer/tests/fuzzer_launcher_test.cc
@@ -49,11 +49,10 @@ TEST(FuzzerConfigTest, ConfigOnly) {
std::vector<std::string> fuzzer_args = base::SplitString(
output, "\n", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
- EXPECT_EQ(3UL, fuzzer_args.size());
+ EXPECT_EQ(2UL, fuzzer_args.size());
- EXPECT_EQ(fuzzer_args[0], "max_len=random(1337, 31337)");
- EXPECT_EQ(fuzzer_args[1], "timeout=666");
- EXPECT_EQ(fuzzer_args[2], "use_traces=1");
+ EXPECT_EQ(fuzzer_args[0], "some_test_option=test_value");
+ EXPECT_EQ(fuzzer_args[1], "max_len=1024");
}
@@ -73,10 +72,10 @@ TEST(FuzzerConfigTest, ConfigAndDict) {
EXPECT_EQ(4UL, fuzzer_args.size());
- EXPECT_EQ(fuzzer_args[0], "max_len=random(1337, 31337)");
- EXPECT_EQ(fuzzer_args[1], "timeout=666");
- EXPECT_EQ(fuzzer_args[2], "use_traces=1");
- EXPECT_EQ(fuzzer_args[3], "dict=test_config_and_dict.dict");
+ EXPECT_EQ(fuzzer_args[0], "dict=test_config_and_dict.dict");
+ EXPECT_EQ(fuzzer_args[1], "max_len=random(1337, 31337)");
+ EXPECT_EQ(fuzzer_args[2], "timeout=666");
+ EXPECT_EQ(fuzzer_args[3], "use_traces=1");
}
« no previous file with comments | « testing/libfuzzer/tests/fuzzer_config_only_test.options ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698