Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1867833002: [libfuzzer] store custom options in .GN build target instead of a separate file. (Closed)

Created:
4 years, 8 months ago by mmoroz
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] store custom options in .GN build target instead of a separate file. R=aizatsky@chromium.org, dpranke@chromium.org, ifnerno@chromium.org, ochang@chromium.org BUG=539572 Committed: https://crrev.com/062a4a63f28a26da7713416381fb65a59c74a9cc Cr-Commit-Position: refs/heads/master@{#386631}

Patch Set 1 #

Patch Set 2 : Working CL. #

Patch Set 3 : Adding owners for net and media. #

Patch Set 4 : Update reference.md of libFuzzer & CF documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -131 lines) Patch
M media/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
D media/filters/vp8_parser_fuzzertest.options View 1 1 chunk +0 lines, -2 lines 0 comments Download
D media/filters/vp9_parser_fuzzertest.options View 1 1 chunk +0 lines, -2 lines 0 comments Download
M media/test/BUILD.gn View 1 1 chunk +3 lines, -1 line 0 comments Download
D media/test/media_pipeline_integration_fuzzer.options View 1 1 chunk +0 lines, -3 lines 0 comments Download
M net/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D net/base/unescape_url_component_fuzzer.options View 1 1 chunk +0 lines, -2 lines 0 comments Download
M testing/libfuzzer/efficient_fuzzer.md View 1 2 chunks +23 lines, -0 lines 0 comments Download
M testing/libfuzzer/fuzzer_test.gni View 1 2 chunks +22 lines, -31 lines 0 comments Download
M testing/libfuzzer/fuzzers/BUILD.gn View 1 6 chunks +6 lines, -6 lines 0 comments Download
D testing/libfuzzer/fuzzers/icu_uregex_open_fuzzer.options View 1 1 chunk +0 lines, -2 lines 0 comments Download
D testing/libfuzzer/fuzzers/libxml_xml_regexp_compile_fuzzer.options View 1 1 chunk +0 lines, -2 lines 0 comments Download
D testing/libfuzzer/fuzzers/mp4_box_reader_fuzzer.options View 1 1 chunk +0 lines, -2 lines 0 comments Download
D testing/libfuzzer/fuzzers/re2_fuzzer.options View 1 1 chunk +0 lines, -3 lines 0 comments Download
D testing/libfuzzer/fuzzers/v8_regexp_parser_fuzzer.options View 1 1 chunk +0 lines, -2 lines 0 comments Download
D testing/libfuzzer/fuzzers/v8_wasm_fuzzer.options View 1 1 chunk +0 lines, -2 lines 0 comments Download
M testing/libfuzzer/gen_fuzzer_config.py View 1 1 chunk +15 lines, -16 lines 0 comments Download
M testing/libfuzzer/reference.md View 1 2 3 1 chunk +9 lines, -5 lines 0 comments Download
M testing/libfuzzer/tests/BUILD.gn View 1 2 chunks +9 lines, -2 lines 0 comments Download
D testing/libfuzzer/tests/fuzzer_config_and_dict_test.options View 1 1 chunk +0 lines, -20 lines 0 comments Download
D testing/libfuzzer/tests/fuzzer_config_only_test.options View 1 1 chunk +0 lines, -17 lines 0 comments Download
M testing/libfuzzer/tests/fuzzer_launcher_test.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-08 16:37:04 UTC) #3
aizatsky
lgtm please update reference.md
4 years, 8 months ago (2016-04-08 18:28:37 UTC) #4
Dirk Pranke
On 2016/04/08 18:28:37, aizatsky wrote: > lgtm > > please update reference.md Are you referring ...
4 years, 8 months ago (2016-04-08 19:14:40 UTC) #5
aizatsky
On 2016/04/08 19:14:40, Dirk Pranke wrote: > On 2016/04/08 18:28:37, aizatsky wrote: > > lgtm ...
4 years, 8 months ago (2016-04-08 23:42:09 UTC) #6
mmoroz
On 2016/04/08 23:42:09, aizatsky wrote: > On 2016/04/08 19:14:40, Dirk Pranke wrote: > > On ...
4 years, 8 months ago (2016-04-11 10:12:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867833002/60001
4 years, 8 months ago (2016-04-11 10:12:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/166880)
4 years, 8 months ago (2016-04-11 10:26:22 UTC) #12
mmoroz
On 2016/04/11 10:26:22, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-11 12:45:07 UTC) #14
eroman
//net lgtm
4 years, 8 months ago (2016-04-11 17:26:16 UTC) #15
jrummell
media/ lgtm
4 years, 8 months ago (2016-04-11 17:52:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867833002/60001
4 years, 8 months ago (2016-04-12 08:57:16 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-12 09:02:46 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 09:03:56 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/062a4a63f28a26da7713416381fb65a59c74a9cc
Cr-Commit-Position: refs/heads/master@{#386631}

Powered by Google App Engine
This is Rietveld 408576698