Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 186783004: Factor out a BaseContext from JsContext. (Closed)

Created:
6 years, 9 months ago by jcgregorio
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Factor out a BaseContext from JsContext. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13660

Patch Set 1 #

Total comments: 21

Patch Set 2 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -346 lines) Patch
A + experimental/SkV8Example/BaseContext.h View 4 chunks +19 lines, -42 lines 0 comments Download
A experimental/SkV8Example/BaseContext.cpp View 1 1 chunk +286 lines, -0 lines 0 comments Download
M experimental/SkV8Example/JsContext.h View 1 3 chunks +11 lines, -53 lines 0 comments Download
M experimental/SkV8Example/JsContext.cpp View 1 2 chunks +8 lines, -251 lines 0 comments Download
M gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jcgregorio
6 years, 9 months ago (2014-03-04 19:48:24 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/186783004/diff/1/experimental/SkV8Example/BaseContext.cpp File experimental/SkV8Example/BaseContext.cpp (right): https://codereview.chromium.org/186783004/diff/1/experimental/SkV8Example/BaseContext.cpp#newcode27 experimental/SkV8Example/BaseContext.cpp:27: SkCanvas* canvas = BaseContext->getCanvas(); if () ...
6 years, 9 months ago (2014-03-04 20:05:03 UTC) #2
jcgregorio
https://codereview.chromium.org/186783004/diff/1/experimental/SkV8Example/BaseContext.cpp File experimental/SkV8Example/BaseContext.cpp (right): https://codereview.chromium.org/186783004/diff/1/experimental/SkV8Example/BaseContext.cpp#newcode27 experimental/SkV8Example/BaseContext.cpp:27: SkCanvas* canvas = BaseContext->getCanvas(); Done, here and all below. ...
6 years, 9 months ago (2014-03-04 20:29:31 UTC) #3
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 9 months ago (2014-03-04 20:29:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/186783004/20001
6 years, 9 months ago (2014-03-04 20:29:47 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 20:44:36 UTC) #6
Message was sent while issue was closed. 
Change committed as 13660

Powered by Google App Engine
This is Rietveld 408576698