Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 186783003: [CSS Shapes] Add performance tests (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Shapes] Add performance tests Add various performance tests for CSS Shapes taken from https://bugs.webkit.org/show_bug.cgi?id=128188. BUG=349093 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168525

Patch Set 1 #

Patch Set 2 : Remove webkit prefix #

Patch Set 3 : Fix shape.gif #

Patch Set 4 : Fix shape.gif? #

Patch Set 5 : Trying --emulate_svn_auto_props #

Patch Set 6 : All perf tests without the .gif #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -0 lines) Patch
A PerformanceTests/Layout/Shapes/ShapeOutsideContentBox.html View 2 1 chunk +19 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/ShapeOutsideInset.html View 2 1 chunk +19 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/ShapeOutsidePolygonWithMargin.html View 2 1 chunk +20 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/ShapeOutsideRaster.html View 2 1 chunk +19 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/ShapeOutsideRasterWithMargin.html View 2 1 chunk +20 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/ShapeOutsideSimplePolygon.html View 2 1 chunk +19 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/ShapeOutsideStackedPolygons.html View 2 1 chunk +19 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/resources/shapes.css View 1 chunk +7 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/resources/shapes.js View 2 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 43 (0 generated)
Zoltan
6 years, 9 months ago (2014-03-04 19:35:03 UTC) #1
Zoltan
lgtm from me
6 years, 9 months ago (2014-03-04 21:41:10 UTC) #2
rwlbuis
@leviw are these tests acceptable as-is? They take about 3 minutes in total on my ...
6 years, 9 months ago (2014-03-04 22:41:15 UTC) #3
leviw_travelin_and_unemployed
Yeah, they'll just be picked up automatically :) lgtm.
6 years, 9 months ago (2014-03-04 22:56:11 UTC) #4
rwlbuis
On 2014/03/04 22:56:11, Levi wrote: > Yeah, they'll just be picked up automatically :) > ...
6 years, 9 months ago (2014-03-04 23:03:12 UTC) #5
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-04 23:03:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/186783003/20001
6 years, 9 months ago (2014-03-04 23:04:15 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 01:05:54 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=17320
6 years, 9 months ago (2014-03-05 01:05:55 UTC) #9
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-05 01:21:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/186783003/20001
6 years, 9 months ago (2014-03-05 01:24:02 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 02:06:16 UTC) #12
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=17328
6 years, 9 months ago (2014-03-05 02:06:16 UTC) #13
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-05 03:05:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/186783003/20001
6 years, 9 months ago (2014-03-05 03:05:30 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 03:30:57 UTC) #16
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=17336
6 years, 9 months ago (2014-03-05 03:30:58 UTC) #17
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-05 04:18:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/186783003/20001
6 years, 9 months ago (2014-03-05 04:19:26 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 04:43:26 UTC) #20
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=17342
6 years, 9 months ago (2014-03-05 04:43:27 UTC) #21
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-05 15:38:15 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/186783003/40001
6 years, 9 months ago (2014-03-05 15:38:22 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 16:05:28 UTC) #24
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=17390
6 years, 9 months ago (2014-03-05 16:05:29 UTC) #25
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-05 17:22:45 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/186783003/60001
6 years, 9 months ago (2014-03-05 17:23:31 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 18:05:51 UTC) #28
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=17399
6 years, 9 months ago (2014-03-05 18:05:56 UTC) #29
leviw_travelin_and_unemployed
On 2014/03/05 18:05:56, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 9 months ago (2014-03-05 18:42:19 UTC) #30
leviw_travelin_and_unemployed
On 2014/03/05 18:42:19, Levi wrote: > On 2014/03/05 18:05:56, I haz the power (commit-bot) wrote: ...
6 years, 9 months ago (2014-03-05 18:42:43 UTC) #31
rwlbuis
On 2014/03/05 18:42:43, Levi wrote: > On 2014/03/05 18:42:19, Levi wrote: > > On 2014/03/05 ...
6 years, 9 months ago (2014-03-05 18:56:35 UTC) #32
leviw_travelin_and_unemployed
On 2014/03/05 18:56:35, rwlbuis wrote: > On 2014/03/05 18:42:43, Levi wrote: > > On 2014/03/05 ...
6 years, 9 months ago (2014-03-05 19:11:32 UTC) #33
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-05 19:11:40 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/186783003/80001
6 years, 9 months ago (2014-03-05 19:11:51 UTC) #35
rwlbuis
The CQ bit was unchecked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-05 19:12:53 UTC) #36
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-05 19:14:22 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/186783003/80001
6 years, 9 months ago (2014-03-05 19:14:48 UTC) #38
rwlbuis
On 2014/03/05 19:14:48, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 9 months ago (2014-03-05 19:19:17 UTC) #39
rwlbuis
The CQ bit was unchecked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-05 19:42:35 UTC) #40
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-05 19:49:40 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/186783003/100001
6 years, 9 months ago (2014-03-05 19:49:54 UTC) #42
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 19:50:54 UTC) #43
Message was sent while issue was closed.
Change committed as 168525

Powered by Google App Engine
This is Rietveld 408576698