Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1867753006: Revert of Don't apply style elements or PIs with loading imports. (Closed)

Created:
4 years, 8 months ago by rune
Modified:
4 years, 8 months ago
Reviewers:
Timothy Loh, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't apply style elements or PIs with loading imports. (patchset #2 id:20001 of https://codereview.chromium.org/1867513002/ ) Reason for revert: This change is incompatible with what Gecko and Blink used to do when inserting an @import rule with insertRule() into a style element sheet. Inserting a style element with script, immediately followed by an @import insertRule() behaves differently than inserting the style element containing that @import rule in the text because the <style> element is processed before the insertRule. Both Gecko and Blink (without this CL) applies the main stylesheet while the @import inserted with insertRule is loading, while they don't when @import is part of the text node child. The behavior for inserting @import is not specified, and zcorpan reported [1]. [1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=29566 Original issue's description: > Don't apply style elements or PIs with loading imports. > > updateLayoutTreeIgnorePendingStylesheets may resolve styles when sheets > are loading. For link elements, the main stylesheet is not applied if > any of its @imports are still loading. For style elements and > xml-stylesheets, we did apply the contents of the main stylesheet while > its @imports were loading. That means we applied half-baked stylesheets > and we had an inconsistency between link and style. Instead regard > style elements and processing instructions as loading when @imports are > loading. > > BUG=600733 > > Committed: https://crrev.com/456c101025b6c470dce2a6af3b0d70cb2950a980 > Cr-Commit-Position: refs/heads/master@{#385564} TBR=esprehn@chromium.org,timloh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=600733 Committed: https://crrev.com/e0eec65f8c6f763775fbf7df75c52ea6c680ea90 Cr-Commit-Position: refs/heads/master@{#386081}

Patch Set 1 #

Messages

Total messages: 8 (2 generated)
rune
Created Revert of Don't apply style elements or PIs with loading imports.
4 years, 8 months ago (2016-04-08 14:15:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867753006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867753006/1
4 years, 8 months ago (2016-04-08 14:15:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867753006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867753006/1
4 years, 8 months ago (2016-04-08 14:31:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867753006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867753006/1
4 years, 8 months ago (2016-04-08 15:01:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 15:22:38 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 15:24:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0eec65f8c6f763775fbf7df75c52ea6c680ea90
Cr-Commit-Position: refs/heads/master@{#386081}

Powered by Google App Engine
This is Rietveld 408576698