headless: Add error reporter utility

headless: Add error reporter utility

Add an error reporter utility which will be used by the generated client
API types to report parsing errors.

BUG=595353
Committed: https://crrev.com/8ad264eaea327495d80c35fbb2dd00a4a318694c
Cr-Commit-Position: refs/heads/master@{#386400}

[Sami, 2016-04-08 12:23:45]

Description was changed from

==========
headless: Add error reporter utility

Add an error reporter utility which will be used by the generated client
API types to report parsing errors.

BUG=595353
==========

to

==========
headless: Add error reporter utility

Add an error reporter utility which will be used by the generated client
API types to report parsing errors.

BUG=595353
==========

[Sami, 2016-04-08 12:23:45]

skyostil@chromium.org changed reviewers:
+ alexclarke@chromium.org, altimin@chromium.org

[altimin, 2016-04-11 14:49:57]

https://codereview.chromium.org/1867753005/diff/1/headless/public/util/error_...
File headless/public/util/error_reporter.h (right):

https://codereview.chromium.org/1867753005/diff/1/headless/public/util/error_...
headless/public/util/error_reporter.h:22: void Push();
Can we merge Push and SetName?

[Sami, 2016-04-11 15:04:10]

https://codereview.chromium.org/1867753005/diff/1/headless/public/util/error_...
File headless/public/util/error_reporter.h (right):

https://codereview.chromium.org/1867753005/diff/1/headless/public/util/error_...
headless/public/util/error_reporter.h:22: void Push();
On 2016/04/11 14:49:57, altimin wrote:
> Can we merge Push and SetName?

When parsing a large object the expected usage pattern is like this:

errors.Push();
errors.SetName("field1");
if (failed) errors.AddError("parsing failed");
errors.SetName("field2");
if (failed) errors.AddError("parsing failed");
errors.SetName("field3");
if (failed) errors.AddError("parsing failed");
...
errors.Pop();

Merging Push() and SetName() would add some redundant stack operations to each
field, which I'd like to avoid.

[altimin, 2016-04-11 15:30:05]

https://codereview.chromium.org/1867753005/diff/1/headless/public/util/error_...
File headless/public/util/error_reporter.cc (right):

https://codereview.chromium.org/1867753005/diff/1/headless/public/util/error_...
headless/public/util/error_reporter.cc:33: if (!path_[i])
I wonder if ignoring the rest of the path_ is a good idea to do when nullptr is
encountered (especially when we have to call SetName manually).

DCHECK maybe?

[Sami, 2016-04-11 15:37:16]

https://codereview.chromium.org/1867753005/diff/1/headless/public/util/error_...
File headless/public/util/error_reporter.cc (right):

https://codereview.chromium.org/1867753005/diff/1/headless/public/util/error_...
headless/public/util/error_reporter.cc:33: if (!path_[i])
On 2016/04/11 15:30:05, altimin wrote:
> I wonder if ignoring the rest of the path_ is a good idea to do when nullptr
is
> encountered (especially when we have to call SetName manually).
> 
> DCHECK maybe?

Good idea, added.

[altimin, 2016-04-11 15:47:16]

lgtm

[Sami, 2016-04-11 15:48:10]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-04-11 15:48:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867753005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867753005/40001

[commit-bot: I haz the power, 2016-04-11 16:23:15]

Description was changed from

==========
headless: Add error reporter utility

Add an error reporter utility which will be used by the generated client
API types to report parsing errors.

BUG=595353
==========

to

==========
headless: Add error reporter utility

Add an error reporter utility which will be used by the generated client
API types to report parsing errors.

BUG=595353
==========

[commit-bot: I haz the power, 2016-04-11 16:23:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-11 16:24:54]

Description was changed from

==========
headless: Add error reporter utility

Add an error reporter utility which will be used by the generated client
API types to report parsing errors.

BUG=595353
==========

to

==========
headless: Add error reporter utility

Add an error reporter utility which will be used by the generated client
API types to report parsing errors.

BUG=595353

Committed: https://crrev.com/8ad264eaea327495d80c35fbb2dd00a4a318694c
Cr-Commit-Position: refs/heads/master@{#386400}
==========

[commit-bot: I haz the power, 2016-04-11 16:24:55]

Patchset 3 (id:??) landed as
https://crrev.com/8ad264eaea327495d80c35fbb2dd00a4a318694c
Cr-Commit-Position: refs/heads/master@{#386400}