mac: Remove POSIX shared memory.

mac: Remove POSIX shared memory.

There are no more consumers.

BUG=568284
Committed: https://crrev.com/acc9ec9e73902650962df0c24a209abfc2a827ef
Cr-Commit-Position: refs/heads/master@{#387050}

[erikchen, 2016-04-07 00:38:49]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 00:39:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867733002/20001

[erikchen, 2016-04-07 01:14:19]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 01:14:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867733002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867733002/40001

[commit-bot: I haz the power, 2016-04-07 01:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 01:45:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-04-07 02:27:11]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 02:27:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867733002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867733002/60001

[commit-bot: I haz the power, 2016-04-07 04:30:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 04:30:56]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-04-07 18:27:26]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 18:27:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867733002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867733002/80001

[commit-bot: I haz the power, 2016-04-07 21:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 21:14:33]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2016-04-08 18:53:44]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 18:54:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867733002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867733002/100001

[erikchen, 2016-04-08 22:37:02]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 22:37:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867733002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867733002/120001

[commit-bot: I haz the power, 2016-04-08 23:46:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 23:46:02]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-04-09 00:07:19]

erikchen@chromium.org changed reviewers:
+ amistry@chromium.org, avi@chromium.org, mark@chromium.org,
mseaborn@chromium.org, tsepez@chromium.org

[erikchen, 2016-04-09 00:07:20]

mark: Please review base/
mseaborn: Please review components/nacl
avi: Please review content/
tsepez: Please review ipc/
amistry: Please review mojo/

[Mark Seaborn, 2016-04-09 00:11:38]

On 2016/04/09 00:07:20, erikchen wrote:
> mseaborn: Please review components/nacl

LGTM

[Avi (use Gerrit), 2016-04-09 00:13:40]

https://codereview.chromium.org/1867733002/diff/120001/base/memory/shared_mem...
File base/memory/shared_memory.h (right):

https://codereview.chromium.org/1867733002/diff/120001/base/memory/shared_mem...
base/memory/shared_memory.h:35: #if !(defined(OS_MACOSX) && !defined(OS_IOS))
OMG

Does iOS use this? Can we just say #if !defined(OS_MACOSX)? Or do we leave this,
and when we remove the two deprecated fields guarded by the #if, the problem
goes away?

https://codereview.chromium.org/1867733002/diff/120001/base/memory/shared_mem...
File base/memory/shared_memory_unittest.cc (right):

https://codereview.chromium.org/1867733002/diff/120001/base/memory/shared_mem...
base/memory/shared_memory_unittest.cc:477: #if defined(OS_POSIX) &&
!(defined(OS_MACOSX) && !defined(OS_IOS))
Two lines below we lock out ios, so why not just do:

#if defined(OS_POSIX) && !defined(OS_MACOSX)

here, and below remove the iOS #if?

[erikchen, 2016-04-09 00:20:50]

https://codereview.chromium.org/1867733002/diff/120001/base/memory/shared_mem...
File base/memory/shared_memory.h (right):

https://codereview.chromium.org/1867733002/diff/120001/base/memory/shared_mem...
base/memory/shared_memory.h:35: #if !(defined(OS_MACOSX) && !defined(OS_IOS))
On 2016/04/09 00:13:40, Avi wrote:
> OMG
> 
> Does iOS use this? Can we just say #if !defined(OS_MACOSX)? Or do we leave
this,
> and when we remove the two deprecated fields guarded by the #if, the problem
> goes away?

iOS still uses the POSIX implementation for shared memory, as well as all the
POSIX shared memory tests, which require these fields.

https://codereview.chromium.org/1867733002/diff/120001/base/memory/shared_mem...
File base/memory/shared_memory_unittest.cc (right):

https://codereview.chromium.org/1867733002/diff/120001/base/memory/shared_mem...
base/memory/shared_memory_unittest.cc:477: #if defined(OS_POSIX) &&
!(defined(OS_MACOSX) && !defined(OS_IOS))
On 2016/04/09 00:13:40, Avi wrote:
> Two lines below we lock out ios, so why not just do:
> 
> #if defined(OS_POSIX) && !defined(OS_MACOSX)
> 
> here, and below remove the iOS #if?

The lines below prevent the AnonymousExecutable test from running on iOS. The
tests below that continue to run on iOS.

[Avi (use Gerrit), 2016-04-09 00:25:27]

lgtm

[Anand Mistry (off Chromium), 2016-04-09 00:44:59]

LGTM for Mojo with one cleanup request.

https://codereview.chromium.org/1867733002/diff/120001/mojo/edk/embedder/embe...
File mojo/edk/embedder/embedder_unittest.cc (right):

https://codereview.chromium.org/1867733002/diff/120001/mojo/edk/embedder/embe...
mojo/edk/embedder/embedder_unittest.cc:378: TEST_F(EmbedderTest,
MultiprocessMachSharedMemory) {
Delete this test. It only exists because OSX had two options for shm and this
test tested the Mach one. Since OSX always uses Mach now, this test is identical
to the once above.

[erikchen, 2016-04-09 01:19:53]

https://codereview.chromium.org/1867733002/diff/120001/mojo/edk/embedder/embe...
File mojo/edk/embedder/embedder_unittest.cc (right):

https://codereview.chromium.org/1867733002/diff/120001/mojo/edk/embedder/embe...
mojo/edk/embedder/embedder_unittest.cc:378: TEST_F(EmbedderTest,
MultiprocessMachSharedMemory) {
On 2016/04/09 00:44:59, Anand Mistry wrote:
> Delete this test. It only exists because OSX had two options for shm and this
> test tested the Mach one. Since OSX always uses Mach now, this test is
identical
> to the once above.

Done.

[erikchen, 2016-04-09 01:20:00]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-09 01:20:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867733002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867733002/140001

[commit-bot: I haz the power, 2016-04-09 02:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-09 02:28:21]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-04-12 17:08:41]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2016-04-12 17:08:42]

+thakis for base/

[Tom Sepez, 2016-04-12 17:29:49]

lgtm

[Nico, 2016-04-13 01:59:59]

lgtm, nice!

https://codereview.chromium.org/1867733002/diff/140001/mojo/edk/embedder/embe...
File mojo/edk/embedder/embedder_unittest.cc (left):

https://codereview.chromium.org/1867733002/diff/140001/mojo/edk/embedder/embe...
mojo/edk/embedder/embedder_unittest.cc:306: options.type =
base::SharedMemoryHandle::POSIX;
this isn't needed? why was this here?

[Anand Mistry (off Chromium), 2016-04-13 12:10:48]

https://codereview.chromium.org/1867733002/diff/140001/mojo/edk/embedder/embe...
File mojo/edk/embedder/embedder_unittest.cc (left):

https://codereview.chromium.org/1867733002/diff/140001/mojo/edk/embedder/embe...
mojo/edk/embedder/embedder_unittest.cc:306: options.type =
base::SharedMemoryHandle::POSIX;
On 2016/04/13 01:59:59, Nico wrote:
> this isn't needed? why was this here?

This was here because we supported both posix and mach shared memory in Mojo.
This test does posix, and the identical one below mach. Now that mach is the
only option, we don't need this flag or the extra test.

[Mark Mentovai, 2016-04-13 15:30:20]

LGTM

(I was on vacation when this came in.)

[Mark Mentovai, 2016-04-13 15:30:34]

P.S. Thanks for the cleanup!

[erikchen, 2016-04-13 16:49:18]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-04-13 16:49:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org, avi@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/1867733002/#ps140001
(title: "Comments from amistry.")

[commit-bot: I haz the power, 2016-04-13 16:49:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867733002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867733002/140001

[commit-bot: I haz the power, 2016-04-13 18:49:40]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-13 18:51:28]

Description was changed from

==========
mac: Remove POSIX shared memory.

There are no more consumers.

BUG=568284
==========

to

==========
mac: Remove POSIX shared memory.

There are no more consumers.

BUG=568284

Committed: https://crrev.com/acc9ec9e73902650962df0c24a209abfc2a827ef
Cr-Commit-Position: refs/heads/master@{#387050}
==========

[commit-bot: I haz the power, 2016-04-13 18:51:30]

Patchset 8 (id:??) landed as
https://crrev.com/acc9ec9e73902650962df0c24a209abfc2a827ef
Cr-Commit-Position: refs/heads/master@{#387050}

[shrike, 2016-04-14 22:54:19]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1890023002/ by shrike@chromium.org.

The reason for reverting is: Looking for the cause of https://crbug.com/603452..