Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 186773005: Move SigninAccountIdHelper away from listening to Signin notifications (Closed)

Created:
6 years, 9 months ago by blundell
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move SigninAccountIdHelper away from listening to Signin notifications As part of eliminating Signin-related notifications, move SigninAccountIdHelper to observing SigninManager. BUG=345622 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M chrome/browser/signin/signin_account_id_helper.h View 2 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/signin/signin_account_id_helper.cc View 3 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blundell
6 years, 9 months ago (2014-03-04 22:02:22 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 9 months ago (2014-03-05 16:01:58 UTC) #2
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 9 months ago (2014-03-05 16:38:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/186773005/1
6 years, 9 months ago (2014-03-05 16:40:29 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 19:46:12 UTC) #5
Message was sent while issue was closed.
Change committed as 255119

Powered by Google App Engine
This is Rietveld 408576698