third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp - Issue 1867693002: Better scrolling fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Issue 1867693002: Better scrolling fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: refined Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

index 382d87c48c8c460ef294f8eb247b94af338adc53..994c3a841ac2a9dd41442d2b243e4f41e50156b1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

@@ -288,13 +288,8 @@ void LayoutFlexibleBox::layoutBlock(bool relayoutChildren)

layoutFlexItems(relayoutChildren, layoutScope);

- ScrollPositionMap scrollMap;

- if (LayoutBlock::finishDelayUpdateScrollInfo(&layoutScope, &scrollMap)) {

+ if (LayoutBlock::finishDelayUpdateScrollInfo(&layoutScope))

layoutFlexItems(false, layoutScope);

- for (auto& entry : scrollMap) {

- entry.key->scrollToPosition(entry.value, ScrollOffsetClamped);

- }

if (logicalHeight() != previousHeight)

relayoutChildren = true;