Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1867693002: Better scrolling fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: refined Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlock.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h
index ae8ca76451fc89bc5ec639a9b7e540aefd2738f8..c7ffc47aaf929b0b64fcd8656e04b9aa2a7e4d50 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h
@@ -341,17 +341,8 @@ protected:
// finishDelayUpdateScrollInfo() will do nothing until finishDelayUpdateScrollInfo()
// is called the same number of times.
// finishDelayUpdateScrollInfo returns true when it marked something for layout.
- // It will also return a map of saved scroll positions that the caller should restore
- // on the given scrollable areas after performing the layout.
- // This can be necessary because Flexbox's multi-pass layout can lose the scroll position.
- // TODO(cbiesinger): This is a temporary hack. The right solution is to delay the scroll
- // clamping that currently happens in PaintLayerScrollableArea::updateAfterLayout to only
- // happen after all layout is done, i.e. during updateLayerPositionsAfterLayout. However,
- // that currently fails a layout test. To fix this bug in time for M50, we use this temporary
- // hack. The real fix is tracked in crbug.com/600036
- typedef PersistentHeapHashMap<Member<PaintLayerScrollableArea>, DoublePoint> ScrollPositionMap;
static void startDelayUpdateScrollInfo();
- static bool finishDelayUpdateScrollInfo(SubtreeLayoutScope*, ScrollPositionMap*);
+ static bool finishDelayUpdateScrollInfo(SubtreeLayoutScope*);
void updateScrollInfoAfterLayout();

Powered by Google App Engine
This is Rietveld 408576698