Better scrolling fix

third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@gmail.com>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 578 matching lines @@
 }
 
 void PaintLayerScrollableArea::computeScrollDimensions()
 {
     m_overflowRect = box().layoutOverflowRect();
     box().flipForWritingMode(m_overflowRect);
 
     int scrollableLeftOverflow = m_overflowRect.x() - box().borderLeft() - (box().shouldPlaceBlockDirectionScrollbarOnLogicalLeft() ? box().verticalScrollbarWidth() : 0);
     int scrollableTopOverflow = m_overflowRect.y() - box().borderTop();
     setScrollOrigin(IntPoint(-scrollableLeftOverflow, -scrollableTopOverflow));
+    fprintf(stderr, "origin=%i,%i\n", scrollOrigin().x(), scrollOrigin().y());
+        fprintf(stderr, "........overflowRect x = %f width = %f layoutRect x = %f width = %f\n", m_overflowRect.x().toFloat(), m_overflowRect.width().toFloat(), box().location().x().toFloat(), box().size().width().toFloat());
+    fprintf(stderr, "offset=%f,%f\n", m_scrollOffset.width(), m_scrollOffset.height());
 }
 
 void PaintLayerScrollableArea::scrollToPosition(const DoublePoint& scrollPosition, ScrollOffsetClamping clamp, ScrollBehavior scrollBehavior, ScrollType scrollType)
 {
     cancelProgrammaticScrollAnimation();
 
     DoublePoint newScrollPosition = clamp == ScrollOffsetClamped ? clampScrollPosition(scrollPosition) : scrollPosition;
     if (newScrollPosition != scrollPositionDouble())
         ScrollableArea::setScrollPosition(newScrollPosition, scrollType, scrollBehavior);
 }
 
+void PaintLayerScrollableArea::clampPositionAfterLayout()
+{
+    // Layout may cause us to be at an invalid scroll position. In this case we need
+    // to pull our scroll offsets back to the max (or push them up to the min).
+    DoublePoint clampedScrollPosition = clampScrollPosition(scrollPositionDouble());
+    if (clampedScrollPosition != scrollPositionDouble())
+        scrollToPosition(clampedScrollPosition);
+}
+
 bool PaintLayerScrollableArea::updateAfterLayout(SubtreeLayoutScope* delayedLayoutScope)
 {
     ASSERT(box().hasOverflowClip());
 
     bool didMarkForDelayedLayout = false;
 
     if (needsScrollbarReconstruction()) {
         m_scrollbarManager.setCanDetachScrollbars(false);
         setHasHorizontalScrollbar(false);
         setHasVerticalScrollbar(false);
     }
 
     m_scrollbarManager.setCanDetachScrollbars(true);
 
     IntPoint originalOrigin = scrollOrigin();
     computeScrollDimensions();
 
-    // Layout may cause us to be at an invalid scroll position. In this case we need
-    // to pull our scroll offsets back to the max (or push them up to the min).
-    DoublePoint clampedScrollPosition = clampScrollPosition(scrollPositionDouble());
-    if (clampedScrollPosition != scrollPositionDouble()) {
-        scrollToPosition(clampedScrollPosition);
-    } else if (originalOrigin != scrollOrigin()) {
+    fprintf(stderr, "updateAfterLayout -- origin is %i,%i offset %f,%f\n", scrollOrigin().x(), scrollOrigin().y(), scrollPositionDouble().x(), scrollPositionDouble().y());
+
+    IntPoint newOrigin(scrollOrigin());
+    if (originalOrigin != newOrigin) {
         // TODO: We should be able to use scrollOriginChanged() here, but we can't because
         // PaintLayerScrollableArea does not maintain that flag: it gets set, but it never
         // gets unset.  We should unset the flag after layout.
-        scrollPositionChanged(scrollPositionDouble(), ProgrammaticScroll);
+        DoubleSize originDiff(newOrigin - originalOrigin);
+        /*
+        if (originDiff.width() < 0)
+            originDiff.setWidth(0);
+        if (originDiff.height() < 0)
+            originDiff.setHeight(0);
+        */
+        scrollPositionChanged(scrollPositionDouble() + originDiff, ProgrammaticScroll);
+        fprintf(stderr, "    adjusting position by %f,%f\n", originDiff.width(), originDiff.height());
     }
 
+
     m_scrollbarManager.setCanDetachScrollbars(false);
 
     bool hasHorizontalOverflow = this->hasHorizontalOverflow();
     bool hasVerticalOverflow = this->hasVerticalOverflow();
 
     {
         // Hits in compositing/overflow/automatically-opt-into-composited-scrolling-after-style-change.html.
         DisableCompositingQueryAsserts disabler;
 
         // overflow:scroll should just enable/disable.
@@ skipping 937 matching lines @@
 }
 
 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager)
 {
     visitor->trace(m_scrollableArea);
     visitor->trace(m_hBar);
     visitor->trace(m_vBar);
 }
 
 } // namespace blink