Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5292)

Unified Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

Issue 1867683002: Disarm LockToOrigin for extensions under --isolate-extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a stupid cast. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/process_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
diff --git a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
index 684fbf44ced6e98dce59a7c0b67d434314cf93f4..db7849125222ffadba3999969ce720f5e71ec6a6 100644
--- a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
+++ b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
@@ -218,6 +218,14 @@ bool ChromeContentBrowserClientExtensionsPart::ShouldLockToOrigin(
.GetExtensionOrAppByURL(effective_site_url);
if (extension && extension->is_hosted_app())
return false;
+
+ // http://crbug.com/600441 workaround: Extension process reuse, implemented
+ // in ShouldTryToUseExistingProcessHost(), means that extension processes
+ // aren't always actually dedicated to a single origin, even in
+ // --isolate-extensions. TODO(nick): Fix this.
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ ::switches::kSitePerProcess))
+ return false;
}
return true;
}
« no previous file with comments | « no previous file | chrome/browser/extensions/process_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698