Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4571)

Unified Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

Issue 1867683002: Disarm LockToOrigin for extensions under --isolate-extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
diff --git a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
index 684fbf44ced6e98dce59a7c0b67d434314cf93f4..d83582c070ef195e9731c865263cefff591a1086 100644
--- a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
+++ b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
@@ -218,6 +218,14 @@ bool ChromeContentBrowserClientExtensionsPart::ShouldLockToOrigin(
.GetExtensionOrAppByURL(effective_site_url);
if (extension && extension->is_hosted_app())
return false;
+
+ // http://crbug.com/600441 workaround - Extension process reuse (implemented
+ // above, in ShouldTryToUseExistingProcessHost) means that extension
Devlin 2016/04/07 15:06:37 nit: actually implemented below, right? Might be
ncarter (slow) 2016/04/07 21:41:09 Done.
+ // processes aren't always actually dedicated to a single origin, even in
+ // --isolate-extensions. TODO(nick): Fix this.
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ ::switches::kSitePerProcess))
+ return false;
}
return true;
}

Powered by Google App Engine
This is Rietveld 408576698