Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1867653003: Fix full snapshot writer code (Closed)

Created:
4 years, 8 months ago by hausner
Modified:
4 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix full snapshot writer code When no vm isolate snapshot buffer is specified, write the vm isolate symbols into the full snapshot. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/728faf448bd5690e1be0d9f0dce9492bc12034f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M runtime/vm/snapshot.cc View 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 8 months ago (2016-04-06 21:28:52 UTC) #3
siva
lgtm
4 years, 8 months ago (2016-04-06 21:30:36 UTC) #4
hausner
4 years, 8 months ago (2016-04-06 22:22:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
728faf448bd5690e1be0d9f0dce9492bc12034f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698