Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1867643002: Revert of Combined test runner. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Combined test runner. (patchset #2 id:20001 of https://codereview.chromium.org/1850273003/ ) Reason for revert: Broke Dr. Memory Original issue's description: > Combined test runner. > > This CL revives the old CL to combine the test runners [1] which was reverted > due to failing font_size tests. I've deleted the font_size.pdf as it is not > needed and for testing. Pixel tests are either .in or .pdf files, not both. > > Original description: > This CL takes the three test runners (corpus, javascript, pixel) and combines > the code into a single test_runner file. Each of the individual runners still > exists and calls the test runner with their data directory. > > With this change, the pixel and javascript test will now run in parallel if > multiple processors are available. > > 1-https://codereview.chromium.org/1430623006/ > > Committed: https://pdfium.googlesource.com/pdfium/+/03e8f12cd3788038225d0376a164a9993f6cb720 TBR=tsepez@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/7a4374583efc0c41c826122aa26c1198c8d5cc37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -244 lines) Patch
A testing/resources/pixel/font_size.pdf View 1 chunk +72 lines, -0 lines 0 comments Download
M testing/tools/run_corpus_tests.py View 1 chunk +164 lines, -3 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 1 chunk +87 lines, -3 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 chunk +95 lines, -3 lines 0 comments Download
D testing/tools/test_runner.py View 1 chunk +0 lines, -235 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dsinclair
Created Revert of Combined test runner.
4 years, 8 months ago (2016-04-06 21:04:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867643002/1
4 years, 8 months ago (2016-04-06 21:04:40 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 21:04:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7a4374583efc0c41c826122aa26c1198c8d5...

Powered by Google App Engine
This is Rietveld 408576698