Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1867633002: Revert "Debug Stub: Added support for windows in ipc_transport." (Closed)

Created:
4 years, 8 months ago by bradnelson
Modified:
4 years, 8 months ago
Reviewers:
bradn, binji, Roland McGrath
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Revert "Debug Stub: Added support for windows in ipc_transport." This change actually ended up breaking nacl debugging on windows. It turns on what was intended to be the new debugging path without keeping the old path sufficiently working. We had intended to direct windows debugging a pipe, however, the chrome side change never landed due to other issues. BUG=chromium:600103 R=binji@chromium.org,mcgrathr@chromium.org This reverts commit d8c34ff8a79c5e6e385f3b39534220090d64e019. Committed: https://chromium.googlesource.com/native_client/src/native_client/+/f84b2da442c06eb324212042970520dc2fcc5e80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -299 lines) Patch
M src/public/chrome_main.h View 2 chunks +11 lines, -13 lines 0 comments Download
M src/trusted/debug_stub/build.scons View 1 chunk +9 lines, -8 lines 0 comments Download
M src/trusted/debug_stub/transport_ipc.cc View 14 chunks +23 lines, -99 lines 0 comments Download
M src/trusted/debug_stub/transport_ipc_test.cc View 4 chunks +49 lines, -172 lines 0 comments Download
M src/trusted/service_runtime/nacl_debug_init.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/sel_main_chrome.c View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bradn
4 years, 8 months ago (2016-04-06 19:47:29 UTC) #2
binji
rubber stamp lgtm
4 years, 8 months ago (2016-04-06 20:52:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867633002/1
4 years, 8 months ago (2016-04-06 20:54:52 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 21:22:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/f84b2da44...

Powered by Google App Engine
This is Rietveld 408576698