remoting/branding_Chrome - Issue 186763004: Add breakpad support for me2me and it2me native messaging host on Mac.

Side by Side Diff: remoting/branding_Chrome

Issue 186763004: Add breakpad support for me2me and it2me native messaging host on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 APK_FILE_NAME=ChromeRemoteDesktop	1 APK_FILE_NAME=ChromeRemoteDesktop

2 APK_PACKAGE_NAME=com.google.chromeremotedesktop	2 APK_PACKAGE_NAME=com.google.chromeremotedesktop

3 DAEMON_FILE_NAME=Chrome Remote Desktop Host Service	3 DAEMON_FILE_NAME=Chrome Remote Desktop Host Service

4 HOST_PLUGIN_FILE_NAME=Chrome Remote Desktop Host	4 HOST_PLUGIN_FILE_NAME=Chrome Remote Desktop Host

5 IT2ME_HOST_DESCRIPTION=Remote Assistance Host for Chrome Remote Desktop	5 IT2ME_HOST_DESCRIPTION=Remote Assistance Host for Chrome Remote Desktop

6 MAC_BUNDLE_ID=com.google.Chrome	6 MAC_BUNDLE_ID=com.google.Chrome

7 MAC_CREATOR=rimZ	7 MAC_CREATOR=rimZ

8 MAC_HOST_BUNDLE_ID=com.google.chromeremotedesktop.me2me-host	8 MAC_HOST_BUNDLE_ID=com.google.chromeremotedesktop.me2me-host

	9 MAC_HOST_BUNDLE_NAME=ChromeRemoteDesktop.Host
	weitao 2014/03/06 18:54:35 Any comment on the bundle names? Any comment on the bundle names? Sergey Ulanov 2014/03/08 02:37:56 Why does it have .Host at the end. I think it can Show quoted text On 2014/03/06 18:54:35, weitaosu wrote: > Any comment on the bundle names? Why does it have .Host at the end. I think it can be ChromeRemoteDesktopHost. Also it looks it's common to use '.bundle' extensions for bundles that are not "Apps" (and host bundle is not an app, it's not normally started by a user), see http://en.wikipedia.org/wiki/Application_bundle. So I think this should be "ChromeRemoteDesktopHost.bundle" weitao 2014/03/19 07:22:36 Done. Show quoted text On 2014/03/08 02:37:56, Sergey Ulanov wrote: > On 2014/03/06 18:54:35, weitaosu wrote: > > Any comment on the bundle names? > > Why does it have .Host at the end. I think it can be ChromeRemoteDesktopHost. > Also it looks it's common to use '.bundle' extensions for bundles that are not > "Apps" (and host bundle is not an app, it's not normally started by a user), see > http://en.wikipedia.org/wiki/Application_bundle. So I think this should be > "ChromeRemoteDesktopHost.bundle" Done.
	10 MAC_NATIVE_MESSAGING_HOST_BUNDLE_ID=com.google.chromeremotedesktop.native-messag ing-host

	11 MAC_NATIVE_MESSAGING_HOST_BUNDLE_NAME=NativeMessagingHost
	Sergey Ulanov 2014/03/08 02:37:56 NativeMessagingHost.bundle But I'm not sure about NativeMessagingHost.bundle But I'm not sure about this one. it can be something like "RemoteDesktopNMHost.bundle" weitao 2014/03/19 07:22:36 Changed the extension from ".app" to ".bundle". I Changed the extension from ".app" to ".bundle". I prefer to keep original base name though. RemoteDesktopNMHost sounds a bit redundant as this bundle is already nested in ChromeRemoteDesktopHost.bundle. It is also more consistent with remote_assistance_host where the bundle name and the binary name are identical. On 2014/03/08 02:37:56, Sergey Ulanov wrote: Show quoted text > NativeMessagingHost.bundle > But I'm not sure about this one. it can be something like > "RemoteDesktopNMHost.bundle"
9 MAC_PREFPANE_BUNDLE_ID=com.google.chromeremotedesktop.preferences	12 MAC_PREFPANE_BUNDLE_ID=com.google.chromeremotedesktop.preferences

	13 MAC_PREFPANE_BUNDLE_NAME=ChromeRemoteDesktop.prefPane

	14 MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_ID=com.google.chromeremotedesktop.remote-assis tance-host

	15 MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_NAME=RemoteAssistanceHost
	Sergey Ulanov 2014/03/08 02:37:56 RemoteAssistanceHost.bundle RemoteAssistanceHost.bundle weitao 2014/03/19 07:22:36 Done. Show quoted text On 2014/03/08 02:37:56, Sergey Ulanov wrote: > RemoteAssistanceHost.bundle Done.
	16 MAC_REMOTING_NAME=ChromeRemoteDesktop

10 MAC_UNINSTALLER_BUNDLE_ID=com.google.chromeremotedesktop.me2me-host-uninstaller	17 MAC_UNINSTALLER_BUNDLE_ID=com.google.chromeremotedesktop.me2me-host-uninstaller

11 MAC_UNINSTALLER_BUNDLE_PREFIX=com.google.pkg	18 MAC_UNINSTALLER_BUNDLE_PREFIX=com.google.pkg

12 MAC_UNINSTALLER_NAME=Chrome Remote Desktop Host Uninstaller	19 MAC_UNINSTALLER_NAME=Chrome Remote Desktop Host Uninstaller

13 ME2ME_HOST_DESCRIPTION=Chrome Remote Desktop Host	20 ME2ME_HOST_DESCRIPTION=Chrome Remote Desktop Host

OLD	NEW

« no previous file with comments | « chrome/test/pyautolib/chromoting_helper.py ('k') | remoting/branding_Chromium » ('j') | remoting/host/installer/mac/ChromotingHostService.pkgproj » ('J')