Remove IPWL_NoteNotify and CPWL_Note.

Remove IPWL_NoteNotify and CPWL_Note.

The IPWL_NoteNotify interface was never implemented. In removing, found that
CPWL_Note was never created. Removed both classes. There were a bunch of methods
that were never called that interacted with this code that have also been
removed.

BUG=pdfium:468
Committed: https://pdfium.googlesource.com/pdfium/+/0b5adb6ead171069aa6f8c49c529f1c6d381e155

[dsinclair, 2016-04-06 19:43:09]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-06 19:43:09]

PTAL.

[Lei Zhang, 2016-04-06 20:29:53]

Description was changed from

==========
Remove IPWL_NoteNotify and CPWL_Note.

The IPWL_NoteNotify interface was never implememnted. In removing, found that
CPWL_Note was never created. Removed both classes. There were a bunch of methods
that were never called that interacted with this code that have also been
removed.

BUG=pdfium:468
==========

to

==========
Remove IPWL_NoteNotify and CPWL_Note.

The IPWL_NoteNotify interface was never implemented. In removing, found that
CPWL_Note was never created. Removed both classes. There were a bunch of methods
that were never called that interacted with this code that have also been
removed.

BUG=pdfium:468
==========

[Lei Zhang, 2016-04-06 20:32:49]

https://codereview.chromium.org/1867623002/diff/1/fpdfsdk/pdfwindow/PWL_Note.cpp
File fpdfsdk/pdfwindow/PWL_Note.cpp (right):

https://codereview.chromium.org/1867623002/diff/1/fpdfsdk/pdfwindow/PWL_Note....
fpdfsdk/pdfwindow/PWL_Note.cpp:141: if (CPWL_Wnd* pParent = GetParentWindow()) {
If the remaining block still useful?

https://codereview.chromium.org/1867623002/diff/1/fpdfsdk/pdfwindow/PWL_Note....
fpdfsdk/pdfwindow/PWL_Note.cpp:855: const CPWL_NoteItem*
CPWL_NoteItem::GetNote() const {
Does this have any callers left?

[dsinclair, 2016-04-06 20:42:18]

https://codereview.chromium.org/1867623002/diff/1/fpdfsdk/pdfwindow/PWL_Note.cpp
File fpdfsdk/pdfwindow/PWL_Note.cpp (right):

https://codereview.chromium.org/1867623002/diff/1/fpdfsdk/pdfwindow/PWL_Note....
fpdfsdk/pdfwindow/PWL_Note.cpp:141: if (CPWL_Wnd* pParent = GetParentWindow()) {
On 2016/04/06 20:32:49, Lei Zhang wrote:
> If the remaining block still useful?

I wasn't sure how useful it would be to keep the ASSERT. Removed.

https://codereview.chromium.org/1867623002/diff/1/fpdfsdk/pdfwindow/PWL_Note....
fpdfsdk/pdfwindow/PWL_Note.cpp:855: const CPWL_NoteItem*
CPWL_NoteItem::GetNote() const {
On 2016/04/06 20:32:49, Lei Zhang wrote:
> Does this have any callers left?

Done.

[Tom Sepez, 2016-04-06 20:48:01]

lgtm

[dsinclair, 2016-04-06 20:48:16]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-06 20:48:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867623002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867623002/20001

[commit-bot: I haz the power, 2016-04-06 21:18:44]

Description was changed from

==========
Remove IPWL_NoteNotify and CPWL_Note.

The IPWL_NoteNotify interface was never implemented. In removing, found that
CPWL_Note was never created. Removed both classes. There were a bunch of methods
that were never called that interacted with this code that have also been
removed.

BUG=pdfium:468
==========

to

==========
Remove IPWL_NoteNotify and CPWL_Note.

The IPWL_NoteNotify interface was never implemented. In removing, found that
CPWL_Note was never created. Removed both classes. There were a bunch of methods
that were never called that interacted with this code that have also been
removed.

BUG=pdfium:468

Committed:
https://pdfium.googlesource.com/pdfium/+/0b5adb6ead171069aa6f8c49c529f1c6d381...
==========

[commit-bot: I haz the power, 2016-04-06 21:18:45]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/0b5adb6ead171069aa6f8c49c529f1c6d381...