Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1896)

Unified Diff: chrome/common/chrome_paths.cc

Issue 1867573002: Remove code to locate the NPAPI Flash plugin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_paths.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_paths.cc
diff --git a/chrome/common/chrome_paths.cc b/chrome/common/chrome_paths.cc
index 364a02d3b67a30dac2ce10f73e0150dad625e2ca..9b44155ad22fbe7284932b3f88355dd4f6f1e31d 100644
--- a/chrome/common/chrome_paths.cc
+++ b/chrome/common/chrome_paths.cc
@@ -43,10 +43,6 @@ const base::FilePath::CharType kPepperFlashBaseDirectory[] =
#if defined(OS_MACOSX)
const base::FilePath::CharType kPepperFlashSystemBaseDirectory[] =
FILE_PATH_LITERAL("Internet Plug-Ins/PepperFlashPlayer");
-const base::FilePath::CharType kFlashSystemBaseDirectory[] =
- FILE_PATH_LITERAL("Internet Plug-Ins");
-const base::FilePath::CharType kFlashSystemPluginName[] =
- FILE_PATH_LITERAL("Flash Player.plugin");
#endif
const base::FilePath::CharType kInternalNaClPluginFileName[] =
@@ -90,18 +86,14 @@ bool GetInternalPluginsDirectory(base::FilePath* result) {
}
#if defined(OS_WIN)
-// Gets the Flash path if installed on the system. |is_npapi| determines whether
-// to return the NPAPI of the PPAPI version of the system plugin.
-bool GetSystemFlashFilename(base::FilePath* out_path, bool is_npapi) {
- const wchar_t kNpapiFlashRegistryRoot[] =
- L"SOFTWARE\\Macromedia\\FlashPlayerPlugin";
+// Gets the Pepper Flash path if installed on the system.
+bool GetSystemFlashFilename(base::FilePath* out_path) {
const wchar_t kPepperFlashRegistryRoot[] =
L"SOFTWARE\\Macromedia\\FlashPlayerPepper";
const wchar_t kFlashPlayerPathValueName[] = L"PlayerPath";
- base::win::RegKey path_key(
- HKEY_LOCAL_MACHINE,
- is_npapi ? kNpapiFlashRegistryRoot : kPepperFlashRegistryRoot, KEY_READ);
+ base::win::RegKey path_key(HKEY_LOCAL_MACHINE, kPepperFlashRegistryRoot,
+ KEY_READ);
base::string16 path_str;
if (FAILED(path_key.ReadValue(kFlashPlayerPathValueName, &path_str)))
return false;
@@ -276,7 +268,7 @@ bool PathProvider(int key, base::FilePath* result) {
break;
case chrome::FILE_PEPPER_FLASH_SYSTEM_PLUGIN:
#if defined(OS_WIN)
- if (!GetSystemFlashFilename(&cur, false))
+ if (!GetSystemFlashFilename(&cur))
return false;
#elif defined(OS_MACOSX)
if (!GetLocalLibraryDirectory(&cur))
@@ -289,20 +281,6 @@ bool PathProvider(int key, base::FilePath* result) {
return false;
#endif
break;
- case chrome::FILE_FLASH_SYSTEM_PLUGIN:
-#if defined(OS_WIN)
- if (!GetSystemFlashFilename(&cur, true))
- return false;
-#elif defined(OS_MACOSX)
- if (!GetLocalLibraryDirectory(&cur))
- return false;
- cur = cur.Append(kFlashSystemBaseDirectory);
- cur = cur.Append(kFlashSystemPluginName);
-#else
- // Chrome on other platforms does not supports system NPAPI binaries.
- return false;
-#endif
- break;
case chrome::FILE_LOCAL_STATE:
if (!PathService::Get(chrome::DIR_USER_DATA, &cur))
return false;
« no previous file with comments | « chrome/common/chrome_paths.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698