Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1867563002: Correctly determine if the SUID sandbox will be used for adjusting the OOM score (Closed)

Created:
4 years, 8 months ago by tpopela
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly determine if the SUID sandbox will be used for adjusting the OOM score The SUID sandbox will be used when a path to it is not empty as per the "A non empty sandbox_cmd means we want a SUID sandbox" comment. R=rickyz@chromium.org BUG=601004 Committed: https://crrev.com/c8047e8e3db7bb1878da59f18446b15b123f1edf Cr-Commit-Position: refs/heads/master@{#385723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/zygote_host/zygote_host_impl_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
tpopela
4 years, 8 months ago (2016-04-06 12:15:02 UTC) #1
rickyz (no longer on Chrome)
lgtm, thanks for the fix!
4 years, 8 months ago (2016-04-06 16:21:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867563002/1
4 years, 8 months ago (2016-04-07 11:45:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867563002/1
4 years, 8 months ago (2016-04-07 11:46:35 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c8047e8e3db7bb1878da59f18446b15b123f1edf Cr-Commit-Position: refs/heads/master@{#385723}
4 years, 8 months ago (2016-04-07 12:32:47 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 12:32:47 UTC) #10
Message was sent while issue was closed.
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698