Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 1867553002: Fix crash in SingleWebsitePreferences when clearing cookies. (Closed)

Created:
4 years, 8 months ago by Finnur
Modified:
4 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in SingleWebsitePreferences when clearing cookies. BUG=600232 Committed: https://crrev.com/cc3b777832354634cf3ef0b15724971404825c20 Cr-Commit-Position: refs/heads/master@{#385706}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java View 1 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Finnur
Care taking this one-liner and test before you go OOO?
4 years, 8 months ago (2016-04-06 16:52:17 UTC) #6
Ted C
lgtm w/ a couple nits https://codereview.chromium.org/1867553002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java (right): https://codereview.chromium.org/1867553002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java#newcode634 chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:634: protected void resetSite() { ...
4 years, 8 months ago (2016-04-06 17:15:28 UTC) #7
Finnur
Done. Checking in. https://codereview.chromium.org/1867553002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java (right): https://codereview.chromium.org/1867553002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java#newcode634 chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:634: protected void resetSite() { On 2016/04/06 ...
4 years, 8 months ago (2016-04-07 10:02:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867553002/60001
4 years, 8 months ago (2016-04-07 10:02:44 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 8 months ago (2016-04-07 10:44:08 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 10:45:52 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cc3b777832354634cf3ef0b15724971404825c20
Cr-Commit-Position: refs/heads/master@{#385706}

Powered by Google App Engine
This is Rietveld 408576698