Fix crash in SingleWebsitePreferences when clearing cookies.

Fix crash in SingleWebsitePreferences when clearing cookies.

BUG=600232
Committed: https://crrev.com/cc3b777832354634cf3ef0b15724971404825c20
Cr-Commit-Position: refs/heads/master@{#385706}

[Finnur, 2016-04-06 15:58:04]

Patchset #1 (id:1) has been deleted

[Finnur, 2016-04-06 15:58:15]

Patchset #1 (id:20001) has been deleted

[Finnur, 2016-04-06 15:59:43]

Description was changed from

==========
Fix crash in SingleWebsitePreferences when clearing cookies.

BUG=600232
==========

to

==========
Fix crash in SingleWebsitePreferences when clearing cookies.

BUG=600232
==========

[Finnur, 2016-04-06 15:59:43]

finnur@chromium.org changed reviewers:
+ newt@chromium.org

[Finnur, 2016-04-06 16:52:16]

finnur@chromium.org changed reviewers:
+ tedchoc@chromium.org
- newt@chromium.org

[Finnur, 2016-04-06 16:52:17]

Care taking this one-liner and test before you go OOO?

[Ted C, 2016-04-06 17:15:28]

lgtm w/ a couple nits

https://codereview.chromium.org/1867553002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
(right):

https://codereview.chromium.org/1867553002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:634:
protected void resetSite() {
add @VisibleForTesting otherwise this will fail on release builds (proguarded
out).

Maybe add a one liner javadoc since it's no longer private and we might get folk
trying to call this now.

https://codereview.chromium.org/1867553002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:649:
WebsitePreferenceBridge.nativeClearCookieData(mSite.getAddress().getTitle());
getTitle is a pretty bad name in my opinion for what this does under the
covers...i guess that is a tangent though

[Finnur, 2016-04-07 10:02:29]

Done. Checking in.

https://codereview.chromium.org/1867553002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
(right):

https://codereview.chromium.org/1867553002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:634:
protected void resetSite() {
On 2016/04/06 17:15:27, Ted C (OOO 4.7-4.13) wrote:
> add @VisibleForTesting otherwise this will fail on release builds (proguarded
> out).
> 
> Maybe add a one liner javadoc since it's no longer private and we might get
folk
> trying to call this now.

Done.

https://codereview.chromium.org/1867553002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:649:
WebsitePreferenceBridge.nativeClearCookieData(mSite.getAddress().getTitle());
Yeah, it's bad. :)

[Finnur, 2016-04-07 10:02:34]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-04-07 10:02:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1867553002/#ps60001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-04-07 10:02:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867553002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867553002/60001

[commit-bot: I haz the power, 2016-04-07 10:44:07]

Description was changed from

==========
Fix crash in SingleWebsitePreferences when clearing cookies.

BUG=600232
==========

to

==========
Fix crash in SingleWebsitePreferences when clearing cookies.

BUG=600232
==========

[commit-bot: I haz the power, 2016-04-07 10:44:08]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-04-07 10:45:51]

Description was changed from

==========
Fix crash in SingleWebsitePreferences when clearing cookies.

BUG=600232
==========

to

==========
Fix crash in SingleWebsitePreferences when clearing cookies.

BUG=600232

Committed: https://crrev.com/cc3b777832354634cf3ef0b15724971404825c20
Cr-Commit-Position: refs/heads/master@{#385706}
==========

[commit-bot: I haz the power, 2016-04-07 10:45:52]

Patchset 2 (id:??) landed as
https://crrev.com/cc3b777832354634cf3ef0b15724971404825c20
Cr-Commit-Position: refs/heads/master@{#385706}