Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: chrome/browser/platform_util.cc

Issue 1867533002: (TOBEDELETED)Select downloaded file in the folder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/platform_util_linux.cc » ('j') | chrome/browser/platform_util_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/platform_util.cc
diff --git a/chrome/browser/platform_util.cc b/chrome/browser/platform_util.cc
index 5cd2e45ef73213007c86668bb94730bee4517008..7867559dc6d96afc5afed896786672801e61df5d 100644
--- a/chrome/browser/platform_util.cc
+++ b/chrome/browser/platform_util.cc
@@ -28,7 +28,7 @@ void VerifyAndOpenItemOnBlockingThread(const base::FilePath& path,
base::Bind(callback, OPEN_FAILED_PATH_NOT_FOUND));
return;
}
- if (base::DirectoryExists(path) != (type == OPEN_FOLDER)) {
Evan Stade 2016/04/07 16:58:58 why this change?
maksims (do not use this acc) 2016/04/14 08:30:33 Because OpenItem() function used to send path.DirN
Lei Zhang 2016/04/15 01:39:24 Sorry, but VerifyAndOpenItemOnBlockingThread(), ba
+ if (base::DirectoryExists(path)) {
if (!callback.is_null())
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
base::Bind(callback, OPEN_FAILED_INVALID_TYPE));
« no previous file with comments | « no previous file | chrome/browser/platform_util_linux.cc » ('j') | chrome/browser/platform_util_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698