(TOBEDELETED)Select downloaded file in the folder.

chrome/browser/platform_util_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/platform_util.h"
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/process/kill.h"
 #include "base/process/launch.h"
@@ skipping 30 matching lines @@
   char* disable_gnome_bug_buddy = getenv("GNOME_DISABLE_CRASH_DIALOG");
   if (disable_gnome_bug_buddy &&
       disable_gnome_bug_buddy == std::string("SET_BY_GOOGLE_CHROME"))
     options.environ["GNOME_DISABLE_CRASH_DIALOG"] = std::string();
 
   base::Process process = base::LaunchProcess(argv, options);
   if (process.IsValid())
     base::EnsureProcessGetsReaped(process.Pid());
 }
 
+void XDGMimeGetDefaultDirectoryBrowser(std::string* cmdline_output) {

[Evan Stade, 2016/04/07 16:58:59]

return std::string?

+  std::vector<std::string> command = {"xdg-mime", "query", "default",
+      "inode/directory"};
+  base::GetAppOutput(command, cmdline_output);
+}
+
 void XDGOpen(const base::FilePath& working_directory, const std::string& path) {
   XDGUtil("xdg-open", working_directory, path);
 }
 
 void XDGEmail(const std::string& email) {
   XDGUtil("xdg-email", base::FilePath(), email);
 }
 
+void OpenFileInDefaultDirectoryBrowser(const std::string& directory_browser,
+                                       const base::FilePath& working_directory,
+                                       const std::string& path){
+  XDGUtil(directory_browser, working_directory, path);
+}
+
 }  // namespace
 
 namespace internal {
 
 void PlatformOpenVerifiedItem(const base::FilePath& path, OpenItemType type) {
   switch (type) {
     case OPEN_FILE:
+      DLOG(ERROR) << "PRE";

[Evan Stade, 2016/04/07 16:58:59]

is this for debug?

[maksims (do not use this acc), 2016/04/14 08:30:33]

Yes

[Lei Zhang, 2016/04/15 01:39:24]

We'd prefer if you removed it.

       XDGOpen(path.DirName(), path.value());
       break;
     case OPEN_FOLDER:
+      // We could not select download file in linux, because directory
+      // browsers did not support that before. This feature was implemented
+      // in nautilus in the beginning of 2015.
+      // Thus, check if the default directory browser is nautilus and use
+      // it. If not, use the old method of opening the downloaded file in
+      // directory without highlighting.
+      std::string output;
+      XDGMimeGetDefaultDirectoryBrowser(&output);
+
+      if(output.find("nautilus") != std::string::npos) {

[Evan Stade, 2016/04/07 16:58:59]

what happens if you just do this regardless of what the file browser is?

[maksims (do not use this acc), 2016/04/14 08:30:33]

if there is no nautilus, nothing happens.

[Lei Zhang, 2016/04/15 08:23:13]

And what happens if nautilus is an older version that doesn't support selecting
the file?

+        OpenFileInDefaultDirectoryBrowser("nautilus", path.DirName(),
+            path.value());
+      }
+      else

[Evan Stade, 2016/04/07 16:58:58]

formatting is off

[Lei Zhang, 2016/04/15 01:39:24]

And you need curly braces.

       // The utility process checks the working directory prior to the
       // invocation of xdg-open by changing the current directory into it. This
       // operation only succeeds if |path| is a directory. Opening "." from
       // there ensures that the target of the operation is a directory.  Note
       // that there remains a TOCTOU race where the directory could be unlinked
       // between the time the utility process changes into the directory and the
       // time the application invoked by xdg-open inspects the path by name.
-      XDGOpen(path, ".");
+      XDGOpen(path.DirName(), ".");
       break;
   }
 }
 }  // namespace internal
 
 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  // TODO(estade): It would be nice to be able to select the file in the file
-  // manager, but that probably requires extending xdg-open. For now just show
-  // the folder.
-  OpenItem(profile, full_path.DirName(), OPEN_FOLDER, OpenOperationCallback());
+    OpenItem(profile, full_path, OPEN_FOLDER, OpenOperationCallback());

[Evan Stade, 2016/04/07 16:58:58]

indent is off

 }
 
 void OpenExternal(Profile* profile, const GURL& url) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   if (url.SchemeIs("mailto"))
     XDGEmail(url.spec());
   else
     XDGOpen(base::FilePath(), url.spec());
 }
 
 }  // namespace platform_util