content/renderer/render_view_impl.h - Issue 186753002: Chromium plumbing to use the selection root bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 186753002: Chromium plumbing to use the selection root bounds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase on Blink patch and OS_ANDROID specific Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 2d6e498a5ada64379e6e90167f8e0913c90d0388..880a2d002b77935e315841e03e9582d8a642cfb1 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -711,6 +711,9 @@ class CONTENT_EXPORT RenderViewImpl

virtual void InstrumentDidBeginFrame() OVERRIDE;

virtual void InstrumentDidCancelFrame() OVERRIDE;

virtual void InstrumentWillComposite() OVERRIDE;

+#if defined(OS_ANDROID)

+ virtual void UpdateSelectionRootBounds();

+#endif

protected:

explicit RenderViewImpl(RenderViewImplParams* params);

@@ -953,6 +956,7 @@ class CONTENT_EXPORT RenderViewImpl

bool animate);

void OnPauseVideo();

void OnExtractSmartClipData(const gfx::Rect& rect);

+ void GetSelectionRootBounds(gfx::Rect* bounds) const;

#elif defined(OS_MACOSX)

void OnCopyToFindPboard();

void OnPluginImeCompositionCompleted(const base::string16& text,