Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 }, 422 },
423 423
424 _onReload: function(message) 424 _onReload: function(message)
425 { 425 {
426 var options = /** @type {!ExtensionReloadOptions} */ (message.options || {}); 426 var options = /** @type {!ExtensionReloadOptions} */ (message.options || {});
427 427
428 WebInspector.multitargetNetworkManager.setUserAgentOverride(typeof optio ns.userAgent === "string" ? options.userAgent : ""); 428 WebInspector.multitargetNetworkManager.setUserAgentOverride(typeof optio ns.userAgent === "string" ? options.userAgent : "");
429 var injectedScript; 429 var injectedScript;
430 if (options.injectedScript) 430 if (options.injectedScript)
431 injectedScript = "(function(){" + options.injectedScript + "})()"; 431 injectedScript = "(function(){" + options.injectedScript + "})()";
432 // TODO(toyoshim): Check if this ignoreCache shouldn't be changed for
dgozman 2016/04/06 15:44:19 This is a public API.
Takashi Toyoshima 2016/04/08 04:50:55 Acknowledged.
433 // DevTools protocol.
432 WebInspector.targetManager.reloadPage(!!options.ignoreCache, injectedScr ipt); 434 WebInspector.targetManager.reloadPage(!!options.ignoreCache, injectedScr ipt);
433 return this._status.OK(); 435 return this._status.OK();
434 }, 436 },
435 437
436 _onEvaluateOnInspectedPage: function(message, port) 438 _onEvaluateOnInspectedPage: function(message, port)
437 { 439 {
438 /** 440 /**
439 * @param {?Protocol.Error} error 441 * @param {?Protocol.Error} error
440 * @param {?WebInspector.RemoteObject} remoteObject 442 * @param {?WebInspector.RemoteObject} remoteObject
441 * @param {boolean=} wasThrown 443 * @param {boolean=} wasThrown
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
1080 1082
1081 /** 1083 /**
1082 * @typedef {{code: string, description: string, details: !Array.<*>}} 1084 * @typedef {{code: string, description: string, details: !Array.<*>}}
1083 */ 1085 */
1084 WebInspector.ExtensionStatus.Record; 1086 WebInspector.ExtensionStatus.Record;
1085 1087
1086 WebInspector.extensionAPI = {}; 1088 WebInspector.extensionAPI = {};
1087 defineCommonExtensionSymbols(WebInspector.extensionAPI); 1089 defineCommonExtensionSymbols(WebInspector.extensionAPI);
1088 1090
1089 /** @type {!WebInspector.ExtensionServer} */ 1091 /** @type {!WebInspector.ExtensionServer} */
1090 WebInspector.extensionServer; 1092 WebInspector.extensionServer;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698