Don't apply style elements or PIs with loading imports.

Don't apply style elements or PIs with loading imports.

updateLayoutTreeIgnorePendingStylesheets may resolve styles when sheets
are loading. For link elements, the main stylesheet is not applied if
any of its @imports are still loading. For style elements and
xml-stylesheets, we did apply the contents of the main stylesheet while
its @imports were loading. That means we applied half-baked stylesheets
and we had an inconsistency between link and style. Instead regard
style elements and processing instructions as loading when @imports are
loading.

BUG=600733
Committed: https://crrev.com/456c101025b6c470dce2a6af3b0d70cb2950a980
Cr-Commit-Position: refs/heads/master@{#385564}

[rune, 2016-04-06 09:24:39]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 09:25:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867513002/1

[commit-bot: I haz the power, 2016-04-06 10:44:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 10:44:30]

Dry run: This issue passed the CQ dry run.

[rune, 2016-04-06 13:20:26]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 13:20:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867513002/20001

[rune, 2016-04-06 13:22:06]

Description was changed from

==========
Don't apply style elements with loading imports.

updateLayoutTreeIgnorePendingStylesheets may resolve styles when sheets
are loading. For link elements, the main stylesheet is not applied if
any of its @imports are still loading. For style elements, we did apply
the contents of the style element while its @imports were loading. That
means we applied half-baked stylesheets and we had an inconsistency
between link and style. Instead regard style elements as loading when
@imports are loading.

BUG=600733
==========

to

==========
Don't apply style elements or PIs with loading imports.

updateLayoutTreeIgnorePendingStylesheets may resolve styles when sheets
are loading. For link elements, the main stylesheet is not applied if
any of its @imports are still loading. For style elements and processing
instructions, we did apply the contents of the style element while its
@imports were loading. That means we applied half-baked stylesheets and
we had an inconsistency between link and style. Instead regard style
elements and processing instructions as loading when @imports are
loading.

BUG=600733
==========

[rune, 2016-04-06 13:22:44]

Added fix for processing instructions (xml-stylesheet) as well.

[rune, 2016-04-06 13:24:54]

Description was changed from

==========
Don't apply style elements or PIs with loading imports.

updateLayoutTreeIgnorePendingStylesheets may resolve styles when sheets
are loading. For link elements, the main stylesheet is not applied if
any of its @imports are still loading. For style elements and processing
instructions, we did apply the contents of the style element while its
@imports were loading. That means we applied half-baked stylesheets and
we had an inconsistency between link and style. Instead regard style
elements and processing instructions as loading when @imports are
loading.

BUG=600733
==========

to

==========
Don't apply style elements or PIs with loading imports.

updateLayoutTreeIgnorePendingStylesheets may resolve styles when sheets
are loading. For link elements, the main stylesheet is not applied if
any of its @imports are still loading. For style elements and
xml-stylesheets, we did apply the contents of the main stylesheet while
its @imports were loading. That means we applied half-baked stylesheets
and we had an inconsistency between link and style. Instead regard
style elements and processing instructions as loading when @imports are
loading.

BUG=600733
==========

[rune, 2016-04-06 14:04:18]

rune@opera.com changed reviewers:
+ esprehn@chromium.org, timloh@chromium.org

[commit-bot: I haz the power, 2016-04-06 14:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 14:45:54]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-04-06 21:03:17]

lgtm

https://codereview.chromium.org/1867513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp (right):

https://codereview.chromium.org/1867513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp:85: StyleSheet* sheet
= this->sheet();
hmm, can we not make this->sheet() and sheet->disabled() work for <link> ?

[rune, 2016-04-06 22:01:47]

https://codereview.chromium.org/1867513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp (right):

https://codereview.chromium.org/1867513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp:85: StyleSheet* sheet
= this->sheet();
On 2016/04/06 21:03:17, esprehn wrote:
> hmm, can we not make this->sheet() and sheet->disabled() work for <link> ?

Sheet is null while top-level css is loading for <link>. Relying on
this->sheet() to be non-null would change the behavior for setting the preferred
stylesheet via <link> title. Relying on sheet for load status of xml-stylesheet
is probably wrong for preferred stylesheet set via its title attribute. I don't
think we should try to fix that in this CL, though.

[rune, 2016-04-06 22:02:15]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-04-06 22:03:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867513002/20001

[commit-bot: I haz the power, 2016-04-06 22:13:38]

Description was changed from

==========
Don't apply style elements or PIs with loading imports.

updateLayoutTreeIgnorePendingStylesheets may resolve styles when sheets
are loading. For link elements, the main stylesheet is not applied if
any of its @imports are still loading. For style elements and
xml-stylesheets, we did apply the contents of the main stylesheet while
its @imports were loading. That means we applied half-baked stylesheets
and we had an inconsistency between link and style. Instead regard
style elements and processing instructions as loading when @imports are
loading.

BUG=600733
==========

to

==========
Don't apply style elements or PIs with loading imports.

updateLayoutTreeIgnorePendingStylesheets may resolve styles when sheets
are loading. For link elements, the main stylesheet is not applied if
any of its @imports are still loading. For style elements and
xml-stylesheets, we did apply the contents of the main stylesheet while
its @imports were loading. That means we applied half-baked stylesheets
and we had an inconsistency between link and style. Instead regard
style elements and processing instructions as loading when @imports are
loading.

BUG=600733
==========

[commit-bot: I haz the power, 2016-04-06 22:13:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 22:14:29]

Description was changed from

==========
Don't apply style elements or PIs with loading imports.

updateLayoutTreeIgnorePendingStylesheets may resolve styles when sheets
are loading. For link elements, the main stylesheet is not applied if
any of its @imports are still loading. For style elements and
xml-stylesheets, we did apply the contents of the main stylesheet while
its @imports were loading. That means we applied half-baked stylesheets
and we had an inconsistency between link and style. Instead regard
style elements and processing instructions as loading when @imports are
loading.

BUG=600733
==========

to

==========
Don't apply style elements or PIs with loading imports.

updateLayoutTreeIgnorePendingStylesheets may resolve styles when sheets
are loading. For link elements, the main stylesheet is not applied if
any of its @imports are still loading. For style elements and
xml-stylesheets, we did apply the contents of the main stylesheet while
its @imports were loading. That means we applied half-baked stylesheets
and we had an inconsistency between link and style. Instead regard
style elements and processing instructions as loading when @imports are
loading.

BUG=600733

Committed: https://crrev.com/456c101025b6c470dce2a6af3b0d70cb2950a980
Cr-Commit-Position: refs/heads/master@{#385564}
==========

[commit-bot: I haz the power, 2016-04-06 22:14:31]

Patchset 2 (id:??) landed as
https://crrev.com/456c101025b6c470dce2a6af3b0d70cb2950a980
Cr-Commit-Position: refs/heads/master@{#385564}

[rune, 2016-04-08 14:14:59]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1867753006/ by rune@opera.com.

The reason for reverting is: This change is incompatible with what Gecko and
Blink used to do when inserting an @import rule with insertRule() into a style
element sheet.

Inserting a style element with script, immediately followed by an @import
insertRule() behaves differently than inserting the style element containing
that @import rule in the text because the <style> element is processed before
the insertRule. Both Gecko and Blink (without this CL) applies the main
stylesheet while the @import inserted with insertRule is loading, while they
don't when @import is part of the text node child.

The behavior for inserting @import is not specified, and zcorpan reported [1].

[1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=29566
.