Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1867463003: Avoid disk read when warming shared prefs. (Closed)

Created:
4 years, 8 months ago by Peter Wen
Modified:
4 years, 8 months ago
Reviewers:
Ted C, hartmanng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid disk read when warming shared prefs. BUG=599284 Committed: https://crrev.com/da6e5418999e9add4164a171d2f056c38ca00ca8 Cr-Commit-Position: refs/heads/master@{#385718}

Patch Set 1 #

Patch Set 2 : Execute async task only for N. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 1 2 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Peter Wen
You think we can get this in before M51 branch? If not I'll have to ...
4 years, 8 months ago (2016-04-06 14:47:10 UTC) #2
hartmanng
lgtm
4 years, 8 months ago (2016-04-06 14:50:08 UTC) #3
Peter Wen
Thanks for the quick review, Glenn! +tedchoc@ for ChromeBrowserInitializer OWNERS.
4 years, 8 months ago (2016-04-06 14:52:05 UTC) #5
Ted C
lgtm
4 years, 8 months ago (2016-04-06 16:18:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867463003/1
4 years, 8 months ago (2016-04-06 17:00:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/49439)
4 years, 8 months ago (2016-04-06 19:03:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867463003/20001
4 years, 8 months ago (2016-04-07 12:02:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 12:08:15 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 12:09:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da6e5418999e9add4164a171d2f056c38ca00ca8
Cr-Commit-Position: refs/heads/master@{#385718}

Powered by Google App Engine
This is Rietveld 408576698