Make static FX_WCHAR arrays more const.

Make static FX_WCHAR arrays more const.

Committed: https://pdfium.googlesource.com/pdfium/+/98a689f63282cfcae1e70f9a1303e56c3b4ce13e

[Lei Zhang, 2016-04-06 01:17:25]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-04-06 17:08:22]

lgtm

[Lei Zhang, 2016-04-06 19:12:47]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-04-06 19:13:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867463002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867463002/1

[commit-bot: I haz the power, 2016-04-06 19:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 19:13:13]

Failed to apply patch for xfa/fxfa/parser/xfa_document_serialize.cpp:
While running git apply --index -3 -p1;
  error: patch failed: xfa/fxfa/parser/xfa_document_serialize.cpp:429
  Falling back to three-way merge...
  Applied patch to 'xfa/fxfa/parser/xfa_document_serialize.cpp' with conflicts.
  U xfa/fxfa/parser/xfa_document_serialize.cpp

Patch:       xfa/fxfa/parser/xfa_document_serialize.cpp
Index: xfa/fxfa/parser/xfa_document_serialize.cpp
diff --git a/xfa/fxfa/parser/xfa_document_serialize.cpp
b/xfa/fxfa/parser/xfa_document_serialize.cpp
index
39590f6e8f8c1e4fc9f3fe3a84dfe374bf698cef..010307837bf0912925605b83778a96724e65a86a
100644
--- a/xfa/fxfa/parser/xfa_document_serialize.cpp
+++ b/xfa/fxfa/parser/xfa_document_serialize.cpp
@@ -429,11 +429,11 @@ void XFA_DataExporter_RegenerateFormFile(CXFA_Node* pNode,
                                          const FX_CHAR* pChecksum,
                                          FX_BOOL bSaveXML) {
   if (pNode->GetObjectType() == XFA_OBJECTTYPE_ModelNode) {
-    static const FX_WCHAR* s_pwsTagName = L"<form";
-    static const FX_WCHAR* s_pwsClose = L"</form\n>";
+    static const FX_WCHAR s_pwsTagName[] = L"<form";
+    static const FX_WCHAR s_pwsClose[] = L"</form\n>";
     pStream->WriteString(s_pwsTagName, FXSYS_wcslen(s_pwsTagName));
     if (pChecksum) {
-      static const FX_WCHAR* s_pwChecksum = L" checksum=\"";
+      static const FX_WCHAR s_pwChecksum[] = L" checksum=\"";
       CFX_WideString wsChecksum =
           CFX_WideString::FromUTF8(pChecksum, FXSYS_strlen(pChecksum));
       pStream->WriteString(s_pwChecksum, FXSYS_wcslen(s_pwChecksum));
@@ -498,14 +498,14 @@ FX_BOOL CXFA_DataExporter::Export(IFX_Stream* pStream,
   if (pNode->GetObjectType() == XFA_OBJECTTYPE_ModelNode) {
     switch (pNode->GetPacketID()) {
       case XFA_XDPPACKET_XDP: {
-        static const FX_WCHAR* s_pwsPreamble =
+        static const FX_WCHAR s_pwsPreamble[] =
             L"<xdp:xdp xmlns:xdp=\"http://ns.adobe.com/xdp/\">";
         pStream->WriteString(s_pwsPreamble, FXSYS_wcslen(s_pwsPreamble));
         for (CXFA_Node* pChild = pNode->GetNodeItem(XFA_NODEITEM_FirstChild);
              pChild; pChild = pChild->GetNodeItem(XFA_NODEITEM_NextSibling)) {
           Export(pStream, pChild, dwFlag, pChecksum);
         }
-        static const FX_WCHAR* s_pwsPostamble = L"</xdp:xdp\n>";
+        static const FX_WCHAR s_pwsPostamble[] = L"</xdp:xdp\n>";
         pStream->WriteString(s_pwsPostamble, FXSYS_wcslen(s_pwsPostamble));
       } break;
       case XFA_XDPPACKET_Datasets: {

[Lei Zhang, 2016-04-06 19:39:31]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-04-06 19:39:32]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1867463002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-06 19:39:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867463002/20001

[commit-bot: I haz the power, 2016-04-06 19:50:36]

Description was changed from

==========
Make static FX_WCHAR arrays more const.
==========

to

==========
Make static FX_WCHAR arrays more const.

Committed:
https://pdfium.googlesource.com/pdfium/+/98a689f63282cfcae1e70f9a1303e56c3b4c...
==========

[commit-bot: I haz the power, 2016-04-06 19:50:37]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/98a689f63282cfcae1e70f9a1303e56c3b4c...