Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 186743002: Types: cache lub bitset to avoid heap access (Closed)

Created:
6 years, 9 months ago by rossberg
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev, Benedikt Meurer
Visibility:
Public.

Description

Types: cache lub bitset to avoid heap access R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19786

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -25 lines) Patch
M src/types.h View 1 9 chunks +35 lines, -19 lines 0 comments Download
M src/types.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-types.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
6 years, 9 months ago (2014-03-04 16:29:56 UTC) #1
Toon Verwaest
lgtm with comment https://codereview.chromium.org/186743002/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/186743002/diff/1/src/types.h#newcode523 src/types.h:523: return 0; I presume this is ...
6 years, 9 months ago (2014-03-10 12:52:18 UTC) #2
rossberg
https://codereview.chromium.org/186743002/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/186743002/diff/1/src/types.h#newcode523 src/types.h:523: return 0; On 2014/03/10 12:52:18, Toon Verwaest wrote: > ...
6 years, 9 months ago (2014-03-11 10:11:38 UTC) #3
rossberg
6 years, 9 months ago (2014-03-11 10:28:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19786 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698