Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1867373003: [Offline pages] Properly mutating bolt icon on incognito tab. (Closed)

Created:
4 years, 8 months ago by fgorski
Modified:
4 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Properly mutating bolt icon on incognito tab. mutate() should be called on the incognito tab before the icon is updated to make sure it does not cause the OIB icon disappear. BUG=601000 R=newt@chromium.org Committed: https://crrev.com/cc5e1779e3e08c42092a4658df824e3f08f50b41 Cr-Commit-Position: refs/heads/master@{#386174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fgorski
PTAL
4 years, 8 months ago (2016-04-08 17:54:17 UTC) #1
newt (away)
lgtm
4 years, 8 months ago (2016-04-08 18:02:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867373003/1
4 years, 8 months ago (2016-04-08 19:02:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 20:00:32 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 20:01:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc5e1779e3e08c42092a4658df824e3f08f50b41
Cr-Commit-Position: refs/heads/master@{#386174}

Powered by Google App Engine
This is Rietveld 408576698