Issue 186733005: Move SVGTextMetricsBuilder metrics computation state to a local helper class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 186733005: Move SVGTextMetricsBuilder metrics computation state to a local helper class (Closed)

Created:
6 years, 9 months ago by fs

Modified:
6 years, 9 months ago

Reviewers:
pdr., f(malita), Stephen Chennney, rwlbuis

CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move SVGTextMetricsBuilder metrics computation state to a local helper class Move all transient state, and methods operating on it, from SVGTextMetricsBuilder to a locally defined helper class (SVGTextMetricsCalculator). This leads to a structure that better represents the life-time of the state, as well as reduce the size of SVGTextLayoutAttributesBuilder (and hence indirectly RenderSVGText.) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168663

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -54 lines)			Patch
	M	Source/core/rendering/svg/SVGTextMetricsBuilder.h	View		2 chunks	+2 lines, -19 lines	0 comments	Download
	M	Source/core/rendering/svg/SVGTextMetricsBuilder.cpp	View		5 chunks	+53 lines, -35 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/186733005/1

6 years, 9 months ago (2014-03-06 18:39:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/186733005/1

6 years, 9 months ago (2014-03-06 19:02:51 UTC) #5

Message was sent while issue was closed.

Change committed as 168663

Expand Messages | Collapse Messages