Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1867323002: [test] Fix simulator config in status files.

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix simulator config in status files. BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M tools/testrunner/local/utils.py View 2 chunks +14 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (1 generated)
Michael Achenbach
PTAL. https://codereview.chromium.org/1867323002/diff/1/tools/testrunner/local/utils.py File tools/testrunner/local/utils.py (right): https://codereview.chromium.org/1867323002/diff/1/tools/testrunner/local/utils.py#newcode99 tools/testrunner/local/utils.py:99: not arch.startswith(machine)) I have no idea if arch.startswith(machine) ...
4 years, 8 months ago (2016-04-08 14:09:22 UTC) #2
Jakob Kummerow
4 years, 8 months ago (2016-04-08 14:55:45 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698